Repository navigation
docs: define supported OTel sampling modes - #304
Open
zhongkechen wants to merge 1 commit into
Open
zhongkechen wants to merge 1 commit into
zhongkechen wants to merge 1 commit into
Conversation
zhongkechen
requested a deployment
to
ai-pr-review
October 30, 2026 19:03 — with
GitHub Actions
Waiting
This was referenced Oct 30, 2026
This branch is waiting to be deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sampling guide describes changing decisions and application persistence without defining which policies durable traces support. Define the two supported modes for both views: an authoritative upstream decision, or deterministic sampling from the stable canonical trace ID with configuration unchanged across retries and reinvocations.
Explain why
Sampled=1overrides localalways_offand ratio policies for durable spans, exclude non-deterministic local policies when no authoritative upstream decision exists, and clarify that in-memory caching is not durable persistence. Configuration and troubleshooting now link to the shared contract.Part of #295. Merge this guide first so the new shared-contract link is available, then merge the coordinated OTel README updates:
Keep #295 open until all four documentation updates land.
This focused change overlaps the broader guide rewrite in #302. Retain the supported sampling modes section and its anchor when combining the changes.
Validation:
git diff --checkpassed. Documentation only; no runtime or cloud tests required.