fix(ci): pass filesystem env vars to e2e-tests-full vitest step#1470
Merged
Conversation
The Secrets Manager step retrieves E2E_EFS_ACCESS_POINT_ARN, E2E_S3_ACCESS_POINT_ARN, E2E_FILESYSTEM_SUBNET_ID, and E2E_FILESYSTEM_SECURITY_GROUP_ID at job scope, but the "Run E2E tests" step's env: block does not propagate them to the vitest subprocess. GitHub Actions does not auto-inherit job-level env vars into step subprocesses, so strands-bedrock-byo-filesystem.test.ts saw undefined values and failed at agentcore create. Symptom on run 27041082542: shards (main, 5/6) and (npm, 5/6) failed with "Create failed:" — only stderr (a Node version warning) was in the assertion message; the actual JSON error went to stdout which the test did not print. The PR-trigger workflow (e2e-tests.yml) already passes these env vars in its Run E2E tests env: block. This change brings e2e-tests-full.yml in line so the byo-filesystem test has the inputs it needs.
Contributor
Package TarballHow to installgh release download pr-1470-tarball --repo aws/agentcore-cli --pattern "*.tgz" --dir /tmp/pr-tarball
npm install -g /tmp/pr-tarball/aws-agentcore-0.17.0.tgz |
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
agentcore-cli-automation
approved these changes
Jun 5, 2026
agentcore-cli-automation
left a comment
There was a problem hiding this comment.
Verified the fix:
- The 4 added env vars exactly match the
requiredEnvVarsine2e-tests/strands-bedrock-byo-filesystem.test.ts(lines 24-29). e2e-tests.ymlalready uses this exact same pattern for both the GA and preview/harness test steps, so this bringse2e-tests-full.ymlin line.- Diagnosis is correct:
aws-secretsmanager-get-secrets@v2writes to job-level env via$GITHUB_ENV, but step-levelenv:blocks must explicitly forward vars into the subprocess — they aren't auto-inherited by spawned children. - Minimal, additive, single-file change. LGTM.
Contributor
Coverage Report
|
notgitika
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
strands-bedrock-byo-filesystem.test.tsfails on theE2E Tests (Full Suite)workflow (e2e-tests-full.yml) at theagentcore createstep:The assertion message only includes
stderr(a Node-version deprecation warning); the actual JSON error went tostdoutwhich the test does not print on failure.Root cause
The Secrets Manager step (
aws-actions/aws-secretsmanager-get-secrets@v2) retrieves these env vars at job scope:E2E_EFS_ACCESS_POINT_ARNE2E_S3_ACCESS_POINT_ARNE2E_FILESYSTEM_SUBNET_IDE2E_FILESYSTEM_SECURITY_GROUP_IDBut the
Run E2E testsstep'senv:block doesn't pass them through, so thevitestsubprocess never sees them. GitHub Actions does not auto-inherit job-level env vars into step subprocesses — they have to be listed explicitly in each step'senv:block.The PR workflow (
e2e-tests.yml) already does this correctly. This PR bringse2e-tests-full.ymlin line.Diff
Type of Change
Why now
CI run 27041082542 (post-merge of #1465 + #1468) had
(main, 5/6)and(npm, 5/6)red because of this. The byo-filesystem test surfaces the missing env vars before any other test would, since other tests don't depend on them. PR is a 4-line additive change to one file.Verification
e2e-tests.ymlfor the same step pattern — confirmed it already passes these 4 varsrequiredEnvVars— matches exactly the 4 env vars added heree2e-tests-full.ymlrun picks up these changesChecklist