Skip to content

fix(idempotency): is_missing_idempotency_key iterates dict keys instead of values #8391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leandrodamascena merged 3 commits into from
Aug 28, 2026
+21 −1
Merged

fix(idempotency): is_missing_idempotency_key iterates dict keys instead of values #8391

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
170848c
fix(idempotency): is_missing_idempotency_key iterates dict keys inste…
Adityaj0 Aug 15, 2026
a959bb0
test(idempotency): cover missing dictionary keys
leandrodamascena Aug 28, 2026
647f138
Merge branch 'develop' into fix-idempotency-key-dict-values
leandrodamascena Aug 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion aws_lambda_powertools/utilities/idempotency/persistence/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,10 @@ def _get_hashed_idempotency_key(self, data: dict[str, Any]) -> str | None:

@staticmethod
def is_missing_idempotency_key(data) -> bool:
if isinstance(data, (tuple, list, dict)):
if isinstance(data, dict):
# JMESPath multi-select dicts retain their keys when all selected values are missing.
return all(x is None for x in data.values())
elif isinstance(data, (tuple, list)):
return all(x is None for x in data)
elif isinstance(data, (int, float, bool)):
return False
Expand Down
17 changes: 17 additions & 0 deletions tests/functional/idempotency/_boto3/test_idempotency.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1046,6 +1046,10 @@ def test_is_missing_idempotency_key():
assert BasePersistenceLayer.is_missing_idempotency_key((None, None))
# GIVEN a dict of Nones THEN is_missing_idempotency_key is True
assert BasePersistenceLayer.is_missing_idempotency_key({None: None})
# GIVEN a dict with all-None values THEN is_missing_idempotency_key is True
assert BasePersistenceLayer.is_missing_idempotency_key({"user": None, "order": None})
# GIVEN a dict with a non-None value THEN is_missing_idempotency_key is False
assert BasePersistenceLayer.is_missing_idempotency_key({"user": "abc"}) is False

# GIVEN True THEN is_missing_idempotency_key is False
assert BasePersistenceLayer.is_missing_idempotency_key(True) is False
Expand Down Expand Up @@ -1114,6 +1118,19 @@ def test_raise_on_no_idempotency_key(
assert "No data found to create a hashed idempotency_key" in str(excinfo.value)


def test_raise_on_no_idempotency_key_for_dict_jmespath(persistence_store: DynamoDBPersistenceLayer):
# GIVEN a dict multi-select expression whose values are missing
idempotency_config = IdempotencyConfig(
event_key_jmespath="{user: headers.user_id, order: body.order_id}",
raise_on_no_idempotency_key=True,
)
persistence_store.configure(idempotency_config)

# WHEN extracting the idempotency key THEN raise IdempotencyKeyError
with pytest.raises(IdempotencyKeyError, match="No data found to create a hashed idempotency_key"):
persistence_store._get_hashed_idempotency_key({"headers": {}, "body": {}})


@pytest.mark.parametrize(
"idempotency_config",
[
Expand Down