chore: add debug flag to LR#166
Merged
tstirrat15 merged 1 commit intomainfrom Apr 28, 2026
Merged
Conversation
|
The latest Buf updates on your PR. Results from workflow Lint / lint (pull_request).
|
miparnisari
previously approved these changes
Apr 27, 2026
tstirrat15
force-pushed
the
tstirrat/add-with-debug-flag-to-lr
branch
from
be15d7d to
2151a70
Compare
tstirrat15
commented
Apr 27, 2026
| ]; | ||
| repeated PermissionRelationshipTree children = 2 [ | ||
| (validate.rules).repeated.items.message.required = true, | ||
| (buf.validate.field).repeated.items.required = true |
Contributor
Author
There was a problem hiding this comment.
This is marked as unenforceable by buf lint, so I'm removing it.
tstirrat15
force-pushed
the
tstirrat/add-with-debug-flag-to-lr
branch
2 times, most recently
from
0c1bcd4 to
501d554
Compare
miparnisari
previously approved these changes
Apr 28, 2026
barakmich
previously approved these changes
Apr 28, 2026
barakmich
left a comment
barakmich
left a comment
There was a problem hiding this comment.
I was gonna be like "a boolean"? But it matches with_tracing so...
Fair enough, and if this becomes more structured in the future, it gets renamed deprecated_with_debug (but then so does with_tracing so, eh)
| // | ||
| // with_debug, if true, indicates that the response should return debug information | ||
| // if present and available. For now, ONLY enables debugging of maximum recursion depth | ||
| // errors; may be extended in the future. |
There was a problem hiding this comment.
Maybe also mention how the debug information is returned in the comment
tstirrat15
force-pushed
the
tstirrat/add-with-debug-flag-to-lr
branch
from
501d554 to
43ccd25
Compare
miparnisari
approved these changes
Apr 28, 2026
barakmich
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
For authzed/spicedb#3070. This adds an additional flag to the LR request body.
Changes
with_debugflagTesting
Review.