-
Notifications
You must be signed in to change notification settings - Fork 46
feat: Support IPSIE session_expiry claim #245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tanya732
wants to merge
7
commits into
v2
Choose a base branch
from
feat/add-ipsie-support
base: v2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
d1683a7
feat: Support IPSIE session_expiry claim
tanya732 9255731
add examples
tanya732 6752500
Merge branch 'v2' into feat/add-ipsie-support
tanya732 d66677c
Merge latest v2 changes
tanya732 68b66ed
fix javadoc
tanya732 00d876e
Merge branch 'feat/add-ipsie-support' of https://github.com/auth0/aut…
tanya732 293507e
Modify docs
tanya732 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| package com.auth0; | ||
|
|
||
| /** | ||
| * Raised when a refresh-token exchange is attempted after the upstream IdP session ceiling | ||
| * ({@code session_expiry}, see the IPSIE SL1 profile) has already passed. | ||
| * <p> | ||
| * The library is stateless and does not own the session, so it cannot know the ceiling on its own: | ||
| * the application persists {@link Tokens#getSessionExpiresAt()} at login and hands it back via | ||
| * {@link RenewAuthRequest#withSessionExpiresAt(Long)}. When that ceiling has passed, | ||
| * {@link RenewAuthRequest#execute()} throws this exception <em>before</em> calling the token | ||
| * endpoint, so a renewed access token can never outlive the session ceiling. The application should | ||
| * treat this as a "must re-authenticate" outcome rather than retrying the refresh. | ||
| * | ||
| * @see RenewAuthRequest#withSessionExpiresAt(Long) | ||
| * @see Tokens#isSessionExpired() | ||
| */ | ||
| @SuppressWarnings("WeakerAccess") | ||
| public class SessionExpiredException extends IdentityVerificationException { | ||
|
|
||
| static final String SESSION_EXPIRED = "a0.session_expired"; | ||
|
|
||
| SessionExpiredException(String message) { | ||
| super(SESSION_EXPIRED, message, null); | ||
| } | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The section explains the claim is in seconds but doesn't warn about what happens when it isn't. Since the value comes from a customer Post-Login Action, the most common mistake is emitting milliseconds (a
getTime()without the/1000), and the code treats anything at or above 10,000,000,000 as "no ceiling". So a milliseconds value doesn't push expiry thousands of years out, it quietly switches enforcement off, which is easy to ship without noticing.Could we add a short warning that the claim must be an integer number of seconds, and that an out of range value is ignored rather than enforced? Refer here: Emitting the claim.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a warning callout in the IPSIE section: the claim must be integer seconds, and an out-of-range value (e.g. milliseconds from a getTime() without /1000) is ignored