build(deps): upgrade to React 19 (coordinated with react-leaflet 5)#114
Merged
Conversation
Bumps react, react-dom, and @types/react(-dom) to 19 in the client. React 19 couldn't land via the standalone Dependabot PRs (#88 bumped react without react-dom, and react-leaflet@4 pins react to ^18) — react-leaflet must move to v5 for React 19 support, so all four are upgraded together. The only react-leaflet API used (MapContainer/TileLayer/Marker/Polyline/Popup/useMap) is unchanged in v5. React 19 type fixes: useRef<T>() now requires an initial arg (-> useRef<T>(undefined), 3 sites), JSX.Element namespace import in FamilyUnitCard, and an explicit React.MouseEvent annotation on a Link onClick. Supersedes Dependabot #88 (react 19) and #104 (react-dom 19). Verified: full build passes; the 18 failing tests are pre-existing better-sqlite3 native-binding failures on main, unrelated to this change.
This was referenced Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades the client to React 19. The standalone Dependabot PRs couldn't land it: #88 bumped
reactwithoutreact-dom, andreact-leaflet@4pinsreactto^18. This bumps all of them together —react,react-dom,@types/react,@types/react-domto 19, andreact-leaflet4→5 (which adds React 19 support). The react-leaflet components used here (MapContainer,TileLayer,Marker,Polyline,Popup,useMap) are unchanged in v5.React 19 type migration fixes
useRef<T>()→useRef<T>(undefined)— React 19 made the initial arg required (3 sites: CopyButton, LinkRelationshipDialog, RelationshipModal).FamilyUnitCard: addedimport type { JSX } from 'react'for theJSX.Elementreturn type.AiDiscoveryModal: explicitReact.MouseEventannotation on aLinkonClick.Supersedes Dependabot #88 and #104.
Test plan
npm run build(shared + server + client) — passes, 0 TS errors.npm test— the 18 failing suites are pre-existingbetter-sqlite3native-binding failures (identical onmainin this environment), unrelated to this change. React/client code compiles clean.