Chore: assert membership where a combination promises no order - #862
Merged
zachdaniel merged 2 commits intoSep 21, 2026
Conversation
mix format --check-formatted fails on main without it.
`first_and_last_post` sorts and limits within each branch and the outer query does not sort, so which of the two rows comes back first is undefined. The assertion named an order, and it named neither the branch order nor the one the base branch selects, so it failed intermittently under the full suite. `with data and sort` covers the ordered case.
Contributor
|
🚀 Thank you for your contribution! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributor checklist
Summary
Two commits:
one fixes a flake in a combination test that assumed an ordering the query doesn't guarantee. The sibling test that does sort is unchanged.
other commit runs the formatter on
uniq_aggregate_sort_test.exsTesting
1001/1004 before and after. There failures are inherited/ash_sql related.