arm64: dts: rockchip: rk3528: drop pcie2x1 skip-reset-in-config

[rpardini]

Skipping the reset assert leaves the controller in whatever state the bootloader handed over, while the combphy is re-initialised underneath it. When the board boots from NVMe the controller is still live, the PIPE clock drops out, and the first DBI read in rk_pcie_host_config() never completes. The rk-pcie probe thread then spins forever in dw_pcie_read(), wedging the CPU until RCU stalls.

The property worked around SRST_PRESETN_CRU_PCIE being asserted, which no longer happens since commit 513192e ("arm64: dts: rockchip: rk3528: Remove pcie2x1 SRST_PRESETN_CRU_PCIE reset").

Fixes: fdb48b9 ("arch: arm64: dts: add rockchip,skip-reset-in-config to pcie2x1 node of rk3528")

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 9fcb10c6-743c-45da-a35e-4b56b2b5cb7c

📥 Commits

Reviewing files that changed from the base of the PR and between f694b5f and 20a7277.

📒 Files selected for processing (1)

• arch/arm64/boot/dts/rockchip/rk3528.dtsi

💤 Files with no reviewable changes (1)

• arch/arm64/boot/dts/rockchip/rk3528.dtsi

Included review availability: Your plan provides up to 2 included reviews per hour; 0 remain after this review.

---

Walkthrough

The RK3528 device-tree configuration no longer sets rockchip,skip-reset-in-config for the pcie2x1 PCIe controller.

Priority: ➖ Normal

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 20a72

No current change or unresolved risk was found in the reviewed PCIe configuration.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely states that the RK3528 PCIe2x1 device-tree property is being removed.
Description check	✅ Passed	The description directly explains the PCIe probe hang, the reset-property cause, and the reason for removing the property.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}