rock 5b/5bp/5t: raise fan PWM to 40 kHz, outside of the hearing range - #533
lukaszsobala wants to merge 1 commit into
Conversation
…tside of the hearing range
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. WalkthroughThe device trees for ROCK 5B, ROCK 5B Plus, and ROCK 5T now use a 25,000 ns PWM period for the fan. The ROCK 5B configuration also defines nine cooling levels instead of five. Estimated code review effort: 1 (Trivial) | ~3 minutes Merge Risk: ⚪ Minimal · up to This change adjusts fan PWM behavior and cooling levels for the affected boards; no actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Narrower than #532 (closed, intentionally split). For a detailed description see that PR. 16.67 kHz makes the fan produce an annoying buzz all the time, so change it to 40 kHz.
Additionally, fix the cooling levels on Rock 5B.
Personally, I am now running this:
But this is a larger change, debatable. The board never exceeds 68 degrees. In my opinion trip points that start at 45 degrees make little sense. Again, the reasoning is in #532.