Skip to content

targets-extensions: enable seeed-extension for reComputer boards - #452

Open
Mkiring wants to merge 2 commits into
armbian:mainfrom
Seeed-Studio:add-seeed-extension-targets
Open

Mkiring wants to merge 2 commits into
armbian:mainfrom
Seeed-Studio:add-seeed-extension-targets

Conversation

@Mkiring

@Mkiring Mkiring commented Sep 14, 2026

Copy link
Copy Markdown

Description

Adds ENABLE_EXTENSIONS="seeed-extension" to release-targets/targets-extensions.map for:

  • recomputer-rk3576-devkit
  • recomputer-rk3588-devkit

Scoped to the vendor branch only — the Seeed extension (OTA support, disk encryption, security hardening, U-Boot postprocess) depends on the vendor U-Boot chain and is not meant for the mainline edge branch.

Dependencies

Requires armbian/build#10698 to land first — that PR adds the seeed-extension wrapper to armbian/build. Merging this before the wrapper exists would fail the vendor-branch CI builds of these two boards with an unknown-extension error. Happy to hold this until that lands.

How Has This Been Tested?

  • Wrapper chain verified on the build side via configdump with ENABLE_EXTENSIONS=seeed-extension on both boards' family config (see extensions: add seeed-extension wrapper pinning Seeed's external repo build#10698): pinned tag:v1.1 fetch + sub-extension cascade resolve cleanly
  • Map syntax follows the BOARD:branch::ENABLE_EXTENSIONS="ext" format consumed by scripts/generate_targets.py:load_extensions_map (vendor-only branch filter parses as {'vendor'})

Add ENABLE_EXTENSIONS=seeed-extension for recomputer-rk3576-devkit and
recomputer-rk3588-devkit, vendor branch only - the Seeed extension
depends on the vendor U-Boot chain, not the mainline edge branch.

Depends on the seeed-extension wrapper extension in armbian/build.
@coderabbitai

coderabbitai Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • release-targets/targets-extensions.map is excluded by !**/*.map

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: b9cb9f3b-47b6-40d7-9204-36741b9bb777

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added size/small PR with less then 50 lines 11 Milestone: Fourth quarter release Needs review Seeking for review labels Sep 14, 2026
igorpecovnik
igorpecovnik previously approved these changes Sep 14, 2026
@github-actions github-actions Bot added the Ready to merge Reviewed, tested and ready for merge label Sep 14, 2026
@github-actions

Copy link
Copy Markdown

✅ This PR has been reviewed and approved — all set for merge!

@github-actions github-actions Bot removed the Needs review Seeking for review label Sep 14, 2026
@github-actions github-actions Bot added Needs review Seeking for review and removed Ready to merge Reviewed, tested and ready for merge labels Sep 15, 2026
@Lesords

Lesords commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Since this PR(https://github.com/armbian/build/pull/10693) has been merged,

board information needs to be added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

11 Milestone: Fourth quarter release Needs review Seeking for review size/small PR with less then 50 lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants