Conversation
Add ENABLE_EXTENSIONS=seeed-extension for recomputer-rk3576-devkit and recomputer-rk3588-devkit, vendor branch only - the Seeed extension depends on the vendor U-Boot chain, not the mainline edge branch. Depends on the seeed-extension wrapper extension in armbian/build.
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ This PR has been reviewed and approved — all set for merge! |
|
Since this PR(https://github.com/armbian/build/pull/10693) has been merged, board information needs to be added. |
Description
Adds
ENABLE_EXTENSIONS="seeed-extension"torelease-targets/targets-extensions.mapfor:recomputer-rk3576-devkitrecomputer-rk3588-devkitScoped to the vendor branch only — the Seeed extension (OTA support, disk encryption, security hardening, U-Boot postprocess) depends on the vendor U-Boot chain and is not meant for the mainline edge branch.
Dependencies
Requires armbian/build#10698 to land first — that PR adds the
seeed-extensionwrapper to armbian/build. Merging this before the wrapper exists would fail the vendor-branch CI builds of these two boards with an unknown-extension error. Happy to hold this until that lands.How Has This Been Tested?
configdumpwithENABLE_EXTENSIONS=seeed-extensionon both boards' family config (see extensions: add seeed-extension wrapper pinning Seeed's external repo build#10698): pinnedtag:v1.1fetch + sub-extension cascade resolve cleanlyBOARD:branch::ENABLE_EXTENSIONS="ext"format consumed byscripts/generate_targets.py:load_extensions_map(vendor-only branch filter parses as{'vendor'})