fix: case insensitive source directory - #45
Merged
Conversation
The rename to `blake3-source` only covered `lakefile.lean`, leaving `.gitignore` and `flake.nix` pointing at the old `blake3` path. The Nix build relies on that path entirely: `disableGitClone` comments out the git calls and `linkBlake3Src` symlinks the pinned source in its place, so a stale path breaks `nix build`. Move the clone under `.lake` instead of the package root. It is already untracked there, so the `.gitignore` entry can go away — which also fixes a latent trap, since git enables `core.ignoreCase` on case-insensitive filesystems and a root-level `/blake3` pattern then also matches the `Blake3` source directory, silently ignoring new files added under it. `lake clean` only clears `.lake/build`, so the clone survives a clean. Since lean4-nix installs `.lake` wholesale, `blake3C` no longer needs to copy the source to `$out` by hand; that copy only existed because the install rsync filters the package root through `.gitignore`. `linkBlake3Src` gains `-fn` so it replaces, rather than dereferences, the symlink that `blake3Test` rsyncs in from the `blake3C` artifacts.
samuelburnham
enabled auto-merge (squash)
August 22, 2026 17:36
johnchandlerburnham
approved these changes
Aug 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends the fix from #40 to the Nix build