Add support for JFrog artifactory.#1553
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1553 +/- ##
==========================================
- Coverage 77.22% 77.08% -0.15%
==========================================
Files 161 163 +2
Lines 15080 15247 +167
==========================================
+ Hits 11646 11753 +107
- Misses 2291 2350 +59
- Partials 1143 1144 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
neolynx
added
needs rebase
|
I was able to publish a small local repo to JFrog, and it seemed to work
fine. This week I'll be testing pushing ubuntu mirrors snapshots to JFrog,
so If I find any issues I will update the PR.
Le lun. 13 avr. 2026 à 12:10, iofq ***@***.***> a écrit :
… ***@***.**** commented on this pull request.
------------------------------
In .github/workflows/ci.yml
<#1553 (comment)>:
> @@ -100,6 +100,9 @@ jobs:
AZURE_STORAGE_ACCESS_KEY: "Eby8vdM02xNOcqFlqUwJPLlmEtlCDXJ1OUzFT50uSRZ6IFsuFq2UVErCz4I6tq/K1SZFPTOtr/KBHBeksoGMGw=="
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
+ JFROG_URL: ${{ secrets.JFROG_URL }}
No I think it's very interesting, having used Artifactory's built in
"Debian Snapshots" before, this would be a welcome improvement :)
I was wondering how we could see it in action, but if it's worked for your
personal needs, that's a good vote of confidence.
—
Reply to this email directly, view it on GitHub
<#1553 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABAHYAIPRWUTJPBKYVOHZPL4VUGNTAVCNFSM6AAAAACXPTAVMKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHM2DCMBQGE3DGMZQHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
| "}") | ||
| } | ||
|
|
||
| func (s *ConfigSuite) TestLoadYAMLConfig(c *C) { |
There was a problem hiding this comment.
Looks like a few tests were removed here, was that intentional?
| github.com/aws/aws-sdk-go-v2/service/s3 v1.67.1 | ||
| github.com/aws/smithy-go v1.22.1 | ||
| github.com/google/uuid v1.6.0 | ||
| github.com/jfrog/jfrog-client-go v1.55.0 |
There was a problem hiding this comment.
I believe if we add a new dependency, it should also be added to debian/control to facilitate debian source builds. However I'm not super familiar with this process and will defer to @neolynx on if this is necessary now and if so, what the process is (since it doesn't look like jfrog-client-go is currently packaged for Debian)
There was a problem hiding this comment.
I guess what I can do is gate JFrog support out of Debian builds for now (build tags / packaging split), so Debian source builds remain reproducible. Let me know how to proceed.
There was a problem hiding this comment.
I am updating the build/debian branch, jfrog support and others will be merged in once debian provides the dependencies. I am in contact with the debian maintainer, we try to get dependencies packaged...
on master we aim to have latest features in and available in the next prod release.
|
I was "playing" with this in my customer's environment today. I had a small bug but now it's working beautifully. I was able to publish, update, and delete from JFrog. I will update the PR and address your comments shortly. |
neolynx
force-pushed
the
feat/pls/jfrog-support
branch
2 times, most recently
from
9b64a58 to
eb48de2
Compare
neolynx
added
needs review
|
rebased, remove binary from git history |
|
Made two commits to update docs and allow credentials to be pulled from env var, please cherry-pick them if they look OK: |
- Remove unused pathCache field from PublishedStorage struct - Remove unused md5s accumulation in Filelist() - Fix unchecked error return on expectedOut.Write in config_test.go - Suppress unused linter on configFileYAML/configFileYAMLError constants (retained to avoid merge conflicts with feat/pls/gcs-support) - Add --timeout=10m to golangci-lint workflow
v0.5.14 introduced a `1 << 31` constant assigned to an `int` variable in lzma/reader.go, which overflows on 32-bit architectures (i386, armhf). v0.5.15 fixes this by using int64.
neolynx
force-pushed
the
feat/pls/jfrog-support
branch
from
eb48de2 to
27bd0f8
Compare
|
@iofq thanks ;-) PR updated |
3 participants
Description of the Change
Add support for JFrog artifactory.
One could use a "generic" JFrog repository (not debian/apt compatible repo: we wouldn't want it to recalculate Release files)
Checklist
AUTHORS