Repository navigation
Add early data to seekable request bodies - #194
Open
guoye-zhang wants to merge 1 commit into
Open
guoye-zhang wants to merge 1 commit into
guoye-zhang wants to merge 1 commit into
Conversation
A client that sends a request in TLS early data (0-RTT, RFC 8470) has to send the start of the body with the request head, before the connection is established, and a seekable body's `produce(offset:into:)` can only deliver it after the client has a writer for the connection. `HTTPEarlyData` holds the first bytes of a body and whether they're the whole body, and a seekable body can provide it through `earlyData`, an optional async closure. A client that sends the early data continues the body from its end with `produce(offset:into:)`, unless it was the whole body; nil means none is available and the body is produced from the start. `seekable(knownLength:earlyData:_:)` takes it, defaulting to nil; restartable bodies have none; mapping a body to another writer keeps it.
Member
|
Why do we limit this to seekable requests only? |
Collaborator
Author
|
When early data is accepted but it’s not the complete body, we need to continue uploading from where it ended so it must be seekable. We usually send the first ~10KB in early data. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A client that sends a request in TLS early data (0-RTT, RFC 8470) has to send the start of the body with the request head, before the connection is established, and a seekable body's
produce(offset:into:)can only deliver it after the client has a writer for the connection.HTTPEarlyDataholds the first bytes of a body and whether they're the whole body, and a seekable body can provide it throughearlyData, an optional async closure. A client that sends the early data continues the body from its end withproduce(offset:into:), unless it was the whole body; nil means none is available and the body is produced from the start.seekable(knownLength:earlyData:_:)takes it, defaulting to nil; restartable bodies have none; mapping a body to another writer keeps it.