Propagate permissions for all host-to-container socket mounts.#1751
Merged
Conversation
- Closes apple#1750. - Applies permission code used for the `--ssh` mount to all host-to-container socket mounts. - Adds a user option to the `doExec` test support function. - Updates the `testRunCommandUnixSocketMount` to install `nc` in the test container, and check the socket permission, and check the mounted socket using `nc` as the guest user.
Code Coverage
|
katiewasnothere
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--sshmount to all host-to-container socket mounts.doExectest support function.testRunCommandUnixSocketMountto installncin the test container, and check the socket permission, and check the mounted socket usingncas the guest user.Type of Change
Motivation and Context
Allows socket mounts for non-user workloads.
Testing