fix: use wdFrame instead of raw frame for scroll gesture anchor - #1256
Merged
Conversation
anchorElement.frame can be pre-scaled for compatibility-mode window mismatches or dimension-swapped in landscape, neither of which scrollingFrame (snapshot-derived) reflects - causing scroll gestures to land outside the scroll view. wdFrame matches scrollingFrame's coordinate space instead. Follow-up to #1249 per review discussion on that PR (appium/appium#16185). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01U6fXkU2kt87W6cmWPyoBgF
KazuCocoa
approved these changes
Sep 10, 2026
Author
|
thanks for review @KazuCocoa |
Member
|
yup, looks good to me @mykola-mokhnach |
github-actions Bot
pushed a commit
that referenced
this pull request
Sep 11, 2026
## [16.12.8](v16.12.7...v16.12.8) (2026-09-11) ### Bug Fixes * use wdFrame instead of raw frame for scroll gesture anchor ([#1256](#1256)) ([9ada9fd](9ada9fd))
|
🎉 This PR is included in version 16.12.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
anchorElement.frame can be pre-scaled for compatibility-mode window mismatches or dimension-swapped in landscape, neither of which scrollingFrame (snapshot-derived) reflects - causing scroll gestures to land outside the scroll view. wdFrame matches scrollingFrame's coordinate space instead. Follow-up to #1249 per review discussion on that PR (appium/appium#16185).