Skip to content

ADFA-4678: Add pre-push nudge to run plugin-review skill#45

Open
hal-eisen-adfa wants to merge 1 commit into
mainfrom
ADFA-4678-nudge-pre-push-plugin-review
Open

ADFA-4678: Add pre-push nudge to run plugin-review skill#45
hal-eisen-adfa wants to merge 1 commit into
mainfrom
ADFA-4678-nudge-pre-push-plugin-review

Conversation

@hal-eisen-adfa

@hal-eisen-adfa hal-eisen-adfa commented Jul 12, 2026

Copy link
Copy Markdown
Contributor

What

Adds an opt-in .githooks/pre-push hook that reminds developers to run the /plugin-review skill when pushing changes to a plugin folder, so peer review isn't spent on issues the skill catches automatically (resource leaks, missing manifest entries, missing in-IDE help).

Resolves ADFA-4678.

How it works

  • The hook reads git's pre-push stdin to find the actual push range, diffs it, and detects which top-level plugin folders changed (dynamically, by grepping each build.gradle.kts for the plugin-builder Gradle plugin).
  • If any plugin folder changed, it prints a reminder naming those folders and the /plugin-review command.
  • It is a nudge, not a gate: always exits 0, never blocks a push, and stays silent for non-plugin pushes (docs-only, libs-only, deletions).

Enabling it (per clone)

Git honors only one core.hooksPath, so the committed hook is inert until enabled once:

./scripts/setup-hooks.sh   # runs: git config core.hooksPath .githooks

Documented in the README's new "Git hooks" section.

Files

  • .githooks/pre-push — the nudge script
  • scripts/setup-hooks.sh — one-time opt-in
  • README.md — "Git hooks" section

Verification

  • Bash syntax check passes.
  • Plugin changed (simulated push range over the layout-editor commit) → prints reminder naming layout-editor, exit 0.
  • No plugin changed → silent, exit 0 (confirmed on this branch's own push).
  • Branch deletion (zero SHA) → silent, exit 0.
  • setup-hooks.sh correctly sets repo-local core.hooksPath=.githooks.

Adds an opt-in .githooks/pre-push hook that reminds developers to run the
/plugin-review skill when pushing changes to a plugin folder, so peer review
isn't spent on issues the skill catches automatically. The hook detects which
top-level plugin folders changed in the push range and names them; it always
exits 0 (reminder only, never blocks) and stays silent for non-plugin pushes.

Because git honors a single core.hooksPath, the hook is enabled per-clone via
scripts/setup-hooks.sh. Documented in the README.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.

Tip: disable this comment in your organization's Code Review settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant