ADFA-4678: Add pre-push nudge to run plugin-review skill#45
Open
hal-eisen-adfa wants to merge 1 commit into
Open
ADFA-4678: Add pre-push nudge to run plugin-review skill#45hal-eisen-adfa wants to merge 1 commit into
hal-eisen-adfa wants to merge 1 commit into
Conversation
Adds an opt-in .githooks/pre-push hook that reminds developers to run the /plugin-review skill when pushing changes to a plugin folder, so peer review isn't spent on issues the skill catches automatically. The hook detects which top-level plugin folders changed in the push range and names them; it always exits 0 (reminder only, never blocks) and stays silent for non-plugin pushes. Because git honors a single core.hooksPath, the hook is enabled per-clone via scripts/setup-hooks.sh. Documented in the README.
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds an opt-in
.githooks/pre-pushhook that reminds developers to run the/plugin-reviewskill when pushing changes to a plugin folder, so peer review isn't spent on issues the skill catches automatically (resource leaks, missing manifest entries, missing in-IDE help).Resolves ADFA-4678.
How it works
build.gradle.ktsfor the plugin-builder Gradle plugin)./plugin-reviewcommand.Enabling it (per clone)
Git honors only one
core.hooksPath, so the committed hook is inert until enabled once:./scripts/setup-hooks.sh # runs: git config core.hooksPath .githooksDocumented in the README's new "Git hooks" section.
Files
.githooks/pre-push— the nudge scriptscripts/setup-hooks.sh— one-time opt-inREADME.md— "Git hooks" sectionVerification
layout-editor, exit 0.setup-hooks.shcorrectly sets repo-localcore.hooksPath=.githooks.