Skip to content

feat(ADFA-2274): Show share button when bottom sheet is half-expanded#1513

Open
dara-abijo-adfa wants to merge 2 commits into
stagefrom
ADFA-2274-share-fab-half-expanded
Open

feat(ADFA-2274): Show share button when bottom sheet is half-expanded#1513
dara-abijo-adfa wants to merge 2 commits into
stagefrom
ADFA-2274-share-fab-half-expanded

Conversation

@dara-abijo-adfa

Copy link
Copy Markdown
Contributor

Jira ticket link

Show the share FAB when the bottom sheet is half-expanded, allowing users to access log sharing whenever the editor bottom sheet is not fully collapsed.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.

Tip: disable this comment in your organization's Code Review settings.

@coderabbitai

coderabbitai Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 541c29ab-4c1b-418d-aa2d-ab09716a5d47

📥 Commits

Reviewing files that changed from the base of the PR and between b755cfd and 0873e12.

📒 Files selected for processing (1)
  • app/src/main/java/com/itsaky/androidide/ui/EditorBottomSheet.kt

📝 Walkthrough
  • Show Share and Clear FABs when the bottom sheet is half-expanded for shareable output tabs.
  • Keep Diagnostics copy FAB visibility synchronized with sheet state and selected tab.
  • Reposition FABs during sliding and after layout changes; remove the layout listener on detachment.
  • Risk: FAB visibility is intentionally not refreshed during dragging or settling, so the previous state remains visible until the transition completes.

Walkthrough

EditorBottomSheet now derives FAB visibility from sheet state and selected content, refreshes it after layout and state changes, and updates FAB translation while the sheet slides.

Changes

Editor bottom sheet FAB behavior

Layer / File(s) Summary
FAB state and positioning
app/src/main/java/com/itsaky/androidide/ui/EditorBottomSheet.kt
FAB visibility is updated from expanded or half-expanded sheet state and the selected tab or fragment. Layout listeners and sheet-state collection trigger refreshes, while sliding recalculates FAB translation. Tab selection now only updates sheet state, and the listener is removed on detachment.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: jatezzz, daniel-adfa, jomen-adfa, itsaky-adfa

Poem

I’m a bunny watching buttons rise,
As the sheet shifts beneath the skies.
Tabs now whisper, states decide,
Three little FABs float with the tide.
Hop, hop—layout keeps them right!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 11.11% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately highlights the main change: showing the share button when the bottom sheet is half-expanded.
Description check ✅ Passed The description clearly matches the change by describing share FAB visibility when the bottom sheet is half-expanded.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ADFA-2274-share-fab-half-expanded

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants