REFACTOR: consolidate duplicate SVG icon components into centralized pattern - #2329
Open
Talha12Shiekh wants to merge 1 commit into
Open
REFACTOR: consolidate duplicate SVG icon components into centralized pattern#2329Talha12Shiekh wants to merge 1 commit into
Talha12Shiekh wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This PR consolidates 12 near-identical SVG icon components in
packages/web/src/components/shared/into a single, scalable pattern, eliminating ~600 lines of duplicated code (~83% boilerplate reduction per icon file).Icons.js): Added a structurediconRegistrymapping icon names (cancel,search,thumbsUp,thumbsDown,mic,mute,listen) to their respective SVG paths,viewBox,xmlns, and keyframe animation styles (@emotion/core).IconComponent: Created a reusable,React.forwardRef-enabledIconcomponent for prop forwarding (onClick,style,className,ref).CancelSvg.js,SearchSvg.js,ThumbsUpSvg.js,ThumbsDownSvg.js,MicSvg.js,MuteSvg.js,ListenSvg.js,AutofillSvg.js,DownloadSvg.js) to thin re-exports fromIcons.js.Checklist
Improvements to the Library Experience
Icons.js).Side Effects
SearchBox,AIAnswer,SelectedFilters, etc.).Testing
yarn build) and verified JSX syntax across all 10 icon files.export default SearchSvg, etc.) export valid React elements without breaking component imports.