test: exclude test/api from test:python so fork PRs stop failing on the missing token - #1449
Open
gerald4277 wants to merge 1 commit into
Open
gerald4277 wants to merge 1 commit into
gerald4277 wants to merge 1 commit into
Conversation
…e missing token Vitest loads every test file before applying --testNamePattern, and test/__setup__/config.ts throws at import when TEST_USER_TOKEN is unset. test:python was the only test script without --exclude ./test/api, so the Python Support job failed on six API suites on every fork PR. Fixes apify#1350 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017eoGxkXnqMCSErCuRHNDUU
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1350.
test:pythonwas the only test script without--exclude ./test/api. Vitest loads every test file before applying--testNamePattern, andtest/__setup__/config.tsthrows at import whenTEST_USER_TOKENis unset. Fork PRs get no secrets, so the Python Support job went red on six API suites with zero Python tests involved.--exclude ./test/apitotest:python, matchingtest:localandtest:e2e.python-scrapy-template-worksis tagged[python] [api]and still runs undertest:api, so internal CI loses no coverage.pnpm run lint,pnpm run format,pnpm run buildpass. No dependency or install-size change.Possible follow-up, not in this PR: move the token check in
test/__setup__/config.tsout of module scope so filtered-out suites never trip it.Disclosure: this change was prepared by an AI agent (Claude, via Claude Code) working under a human's GitHub account. The account owner is accountable for it.