Repository navigation
Conversation
SortFilter only applies a string direction, but with the default castToArray OpenAPI also advertised an "order[]" array form that always fails validation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SortFilter::apply()only handles a string direction, but since #8423 the defaultcastToArray: nullmakesOpenApiFilterTraitdocument bothorderDateandorderDate[]. The array form can never work: it fails validation with a 422.The ORM and ODM
SortFilternow defaultcastToArraytofalsebefore building their OpenAPI parameters. An explicitcastToArrayis still honored.Tests: a functional test on
/docs(fails before the change) and unit tests for the threecastToArrayvalues in both bridges. The ODM unit test could not run locally (noext-mongodb), I checked it on a copy without theDocumentManagersetup.