Repository navigation
[HOTFIX] Update remaining Node.js toolchains to 22.23.4 - #5588
Merged
voidmatcha merged 4 commits intoOct 24, 2026
Merged
Conversation
Replace the end-of-life Node.js 16 pin to address CVE-2026-111497. Keep npm 8.19.4 and all resolved package versions unchanged to isolate the runtime migration. Validation: Maven Node/npm installation; npm ci; npm run build:dist (including lint); npm run karma-test with FirefoxHeadless, 194 tests passed. No OpenSSL legacy provider or webpack changes required.
Replace the end-of-life Node.js 16.16.0 installed by the runtime Helium bundler to address CVE-2026-111497. Retain the current npm, Yarn and webpack versions. Validation: JDK 11 Maven package reactor for zeppelin-server --am with HeliumBundleFactoryTest: 5 tests passed, covering tool installation, npm package download, local and registry bundles, cache reuse and package version switching.
tbonelee
marked this pull request as ready for review
October 24, 2026 13:38
tbonelee
marked this pull request as draft
October 24, 2026 13:46
tbonelee
force-pushed
the
fix/brotli-security-after-5587
branch
from
October 24, 2026 13:50
4b202e8 to
7ccdf09
Compare
voidmatcha
reviewed
Oct 24, 2026
voidmatcha
left a comment
Member
There was a problem hiding this comment.
The Classic UI’s .nvmrc and Maven configuration have been updated to Node.js 22.23.4, but the Local Development section in zeppelin-web/README.md still recommends Node.js v16. Could you update the documentation to match the new version or direct developers to use .nvmrc?
I found no other merge-blocking issues. I also verified that the Classic build and tests, along with the Helium tests on JDK 11 and 17, passed.
Contributor
Author
|
Thanks! I've updated it. |
tbonelee
marked this pull request as ready for review
October 24, 2026 14:34
voidmatcha
approved these changes
Oct 24, 2026
Member
|
Merged into master (65c12bf). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Follow up on #5587 by updating the remaining Node.js toolchains to patched releases. The October 2026 Node.js security release addresses the Brotli decoder vulnerability CVE-2026-111497.
^22.23.4 || ^24.22.1 || >=26.12.1.The existing Classic npm 8.19.4 and Helium npm 8.11.0/Yarn 1.22.0 versions are retained. Application code and dependency resolutions are unchanged apart from the Node.js version selection and engine metadata.
Classic uses Node.js during development and builds; Helium also invokes Node.js on the server to install packages and generate bundles. This updates those toolchains without claiming a confirmed remotely exploitable Zeppelin attack path.
What type of PR is it?
Bug Fix
Todos
What is the Jira issue?
N/A
How should this be tested?
Frontend:
Classic UI:
Helium:
The browser checks also identified an existing Monaco icon font loading error, reproduced with a Node.js 22.21.1 comparison build. These existing issues are outside this change.
The retained Node.js changes are identical to the previously validated versions. After integration with #5587, installation, React tests, typecheck, and frontend builds were repeated. The source tree was unchanged by rebasing onto the merged #5587 commit. The full E2E suite, Storybook build, and final WAR/container packaging were not rerun.
Screenshots (if appropriate)
N/A
Questions:
.nvmrc.