[ZEPPELIN-6702] Fix shell terminal startup hang on macOS with JDK 17.0.13 - #5467
Open
seung-00 wants to merge 1 commit into
Open
[ZEPPELIN-6702] Fix shell terminal startup hang on macOS with JDK 17.0.13#5467seung-00 wants to merge 1 commit into
seung-00 wants to merge 1 commit into
Conversation
pan3793
approved these changes
Sep 9, 2026
pan3793
left a comment
Member
There was a problem hiding this comment.
LGTM, I checked the upgraded pty4j version is built against JDK 11, and it's great to get rid of a 3rd-party maven repo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Upgrade pty4j from
0.12.10-jdk8to0.13.12to avoid excessive shell terminal startup delays with high FD limits.Reproduced on macOS with JDK 17.0.13, where the FD limit was
INT_MAX. The old pty4j iterates through the entire range before starting the shell.JDK 17.0.14 reduced the macOS FD limit, mitigating this issue. Upgrading pty4j avoids excessive startup delays when the FD limit remains high.
Also remove the JetBrains repository declaration, as the updated dependency is available from Maven Central.
What type of PR is it?
Bug Fix
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-6702
How should this be tested?
Verified locally:
On macOS with JDK 17.0.13:
./mvnw test -pl shell -Dtest=TerminalInterpreterTest%sh.terminalparagraph. Confirm that a shell prompt appears.Screenshots (if appropriate)
Questions: