[FIX][TIRx] Traverse pointer expressions in tile calls - #20089
Open
jinhongyii wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
TilePrimitiveCallarguments and config values can contain anytvm.ir.Expr, not onlyPrimExpr. In particular,T.address_of(...)produces a pointer expression.The Python
StmtVisitorandStmtMutatoronly traversed values accepted bytvm.ir.is_prim_expr. Pointer-valued operands were therefore skipped entirely. Analyses could miss buffer uses below the pointer expression, and rewrites could leave stale buffer references behind.Example
A tile call can pass an mbarrier address through its config:
Before this PR, a
StmtExprVisitordid not reach theBufferLoadformbar[0], and aStmtExprMutatorcould not replace it. After this PR, both visitor and mutator traverse the pointer expression normally.What changed
tvm.ir.ExprinTilePrimitiveCallarguments and config values as traversable.T.address_of.Tests
python -m pytest tests/python/tirx/transform/test_stmt_functor.py -q(20 passed)pre-commit run --files python/tvm/tirx/stmt_functor.py tests/python/tirx/transform/test_stmt_functor.pyPorted from mlc-ai/tvm@98b7dec.