Skip to content

hrw4u: admit SESSION_VARS as a denyable section #13696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
masaori335 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

hrw4u: admit SESSION_VARS as a denyable section #13696

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9915947
hrw4u: admit SESSION_VARS as a denyable section
masaori335 Sep 14, 2026
8e7c070
Add suggested doc change
masaori335 Sep 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions doc/admin-guide/configuration/hrw4u.en.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -710,9 +710,9 @@ Denied Sections
---------------

The ``sections`` list accepts any of the HRW4U section names listed in the
`Sections`_ table, plus ``VARS`` to deny the variable declaration block.
A denied section causes the entire block to be rejected; the body is not
validated.
`Sections`_ table, plus ``VARS`` and ``SESSION_VARS`` to deny the variable
declaration blocks. A denied section causes the entire block to be rejected;
the body is not validated.

Functions
---------
Expand Down Expand Up @@ -775,7 +775,7 @@ The ``language`` list accepts a fixed set of constructs:
Construct What it controls
================ ===================================================
``break`` The ``break;`` statement (early section exit)
``variables`` The entire ``VARS`` section and all variable usage
``variables`` The entire ``VARS`` and ``SESSION_VARS`` section and all variable usage
``else`` The ``else { ... }`` branch of conditionals
``elif`` The ``elif ... { ... }`` branch of conditionals
``in`` The ``in [...]`` and ``!in [...]`` set membership operators
Expand Down
3 changes: 2 additions & 1 deletion tools/hrw4u/schema/sandbox.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,8 @@
"READ_RESPONSE",
"SEND_RESPONSE",
"TXN_CLOSE",
"VARS"
"VARS",
"SESSION_VARS"
]
},
"uniqueItems": true
Expand Down
1 change: 1 addition & 0 deletions tools/hrw4u/tests/data/sandbox/denied-section-session-vars.ast.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
(program (programItem (section (sessionVarSection SESSION_VARS { (variables (variablesItem (variableDecl session_marked : bool ;))) }))) (programItem (section REMAP { (sectionBody (statement inbound.req.X-Marked = (value "1") ;)) })) <EOF>)
2 changes: 2 additions & 0 deletions tools/hrw4u/tests/data/sandbox/denied-section-session-vars.error.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
'SESSION_VARS' is denied by sandbox policy (section)
Feature denied by sandbox policy. Contact platform team.
7 changes: 7 additions & 0 deletions tools/hrw4u/tests/data/sandbox/denied-section-session-vars.input.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
SESSION_VARS {
session_marked: bool;
}

REMAP {
inbound.req.X-Marked = "1";
}
6 changes: 6 additions & 0 deletions tools/hrw4u/tests/data/sandbox/denied-section-session-vars.sandbox.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
sandbox:
message: "Feature denied by sandbox policy. Contact platform team."

deny:
sections:
- SESSION_VARS