Route JspC context logging through Ant - #1074
Open
sainadh777 wants to merge 1 commit into
Open
sainadh777 wants to merge 1 commit into
sainadh777 wants to merge 1 commit into
Conversation
Contributor
Author
|
@markt-asf, could you review this JspC Ant logging change? Your exact TestJspC history and review of similar Jasper work make it especially relevant. @rmaucher, your recent direct JspC and neighboring Jasper work would also be valuable here. Formal review requests are unavailable to fork contributors. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rationale
JspCServletContext currently writes log output directly to stdout, bypassing Ant listeners, formatting, and verbosity controls when JspC runs as an Ant task. Using Ant LogOutputStream keeps these messages in the task logging pipeline while retaining the current standalone behavior.
Impact
This is a narrow logging-path change for Ant task use. It does not alter Catalina runtime behavior, and standalone JspC continues to log to stdout.
Validation
For completeness, the Java 21 full-suite diagnostic reached 41,439 tests with no failures but exposed the current upstream TestGroupChannelTlsFFM Java-version teardown issue (12 ClassNotFound errors after the FFM tests were skipped). The definitive Java 25 full-suite run passed cleanly.