Skip to content

Route JspC context logging through Ant - #1074

Open
sainadh777 wants to merge 1 commit into
apache:mainfrom
sainadh777:fix/jspc-ant-context-log
Open

sainadh777 wants to merge 1 commit into
apache:mainfrom
sainadh777:fix/jspc-ant-context-log

Conversation

@sainadh777

Copy link
Copy Markdown
Contributor

Summary

  • Route JspC servlet-context log messages through Ant task logging when an Ant project is present.
  • Preserve stdout logging for standalone JspC use.
  • Add regression coverage and retire TODO 35.1.

Rationale

JspCServletContext currently writes log output directly to stdout, bypassing Ant listeners, formatting, and verbosity controls when JspC runs as an Ant task. Using Ant LogOutputStream keeps these messages in the task logging pipeline while retaining the current standalone behavior.

Impact

This is a narrow logging-path change for Ant task use. It does not alter Catalina runtime behavior, and standalone JspC continues to log to stdout.

Validation

  • ant -Dbase.path=/workspace-cache -Dexecute.validate=true validate — passed; Checkstyle covered 7,714 files.
  • ant -Dbase.path=/workspace-cache -Dtest.entry=org.apache.jasper.TestJspC test — passed; 12 tests, 0 failures/errors.
  • ant -Dbase.path=/workspace-cache clean deploy — passed.
  • ant -Dbase.path=/workspace-cache clean test on Temurin 25.0.4 — passed; 41,439 tests, 0 failures, 0 errors, 362 expected skips.
  • Generated distribution smoke test — Tomcat served HTTP 200, then shut down cleanly and exited 0.

For completeness, the Java 21 full-suite diagnostic reached 41,439 tests with no failures but exposed the current upstream TestGroupChannelTlsFFM Java-version teardown issue (12 ClassNotFound errors after the FFM tests were skipped). The definitive Java 25 full-suite run passed cleanly.

@sainadh777

Copy link
Copy Markdown
Contributor Author

@markt-asf, could you review this JspC Ant logging change? Your exact TestJspC history and review of similar Jasper work make it especially relevant. @rmaucher, your recent direct JspC and neighboring Jasper work would also be valuable here. Formal review requests are unavailable to fork contributors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant