refactor(amber, frontend): remove the never-emitted CacheStatusUpdateEvent - #8690
Open
aglinxinyuan wants to merge 1 commit into
Open
aglinxinyuan wants to merge 1 commit into
aglinxinyuan wants to merge 1 commit into
Conversation
…Event Nothing has constructed CacheStatusUpdateEvent since apache#3111 deleted the EditingTimeCompilationRequest branch of WorkflowWebsocketResource, its only sender. Drop the case class, its @JsonSubTypes registration and spec entries, the frontend interface and type-map entry, and the OperatorReuseCacheStatusService handler that subscribed to it (plus its two tests and the WorkflowWebsocketService dependency it alone used). The service's live reuse-cache repaint subscription stays.
Contributor
Automated Reviewer SuggestionsBased on the
|
Contributor
✅ No material benchmark regressions detected🟢 6 better · 🔴 0 worse · ⚪ 9 noise (<±5%) · 0 without baseline
Baseline detailsLatest main
Raw CSVconfig_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
0,10,10,64,20,471.41,200,128000,424,0.259,23091.20,28194.27,28194.27
1,100,10,64,20,2283.12,2000,1280000,876,0.535,114178.93,126747.43,126747.43
2,1000,10,64,20,19753.59,20000,12800000,1012,0.618,981461.48,1038944.56,1038944.56 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8690 +/- ##
============================================
- Coverage 92.72% 92.72% -0.01%
+ Complexity 4947 4946 -1
============================================
Files 1243 1242 -1
Lines 52682 52672 -10
Branches 6520 6519 -1
============================================
- Hits 48850 48840 -10
Misses 2214 2214
Partials 1618 1618
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
Deletes
CacheStatusUpdateEvent. It is a websocket event the backend has not sent since the websocket cache check was removed, while the frontend kept a subscription to it. There is no behaviour change: +3/−87 lines.Backend: the case class, its
@JsonSubTypesregistration, and its entries inTexeraWebSocketEventSpec.Frontend: the interface and
TexeraWebsocketEventTypeMapentry, and thesubscribeToEvent("CacheStatusUpdateEvent")handler inOperatorReuseCacheStatusServicewith its two tests. The service'sWorkflowWebsocketServicedependency is removed too, because that handler was its only use.History
EditingTimeCompilationRequestbranch ofWorkflowWebsocketResource, the only place that calledsessionState.send(CacheStatusUpdateEvent(...))It has been dead for nearly two years. The frontend handler has been subscribed to an event that never arrives.
Any related issues, documentation, discussions?
Closes #8689
How was this PR tested?
No new tests. The protocol spec now covers only the types that remain registered, and the service spec drops the two cases for the removed handler.
Locally, from the repo root with Java 17:
sbt "WorkflowExecutionService/Test/compile": success.sbt "WorkflowExecutionService/testOnly *TexeraWebSocketEventSpec": 10 tests, all pass.sbt "WorkflowExecutionService/scalafmtCheckAll" "WorkflowExecutionService/scalafixAll --check": clean.From
frontend/:npx ng test --watch=false --include='**/operator-reuse-cache-status.service.spec.ts' --include='**/workflow-websocket.service.spec.ts': 18 tests, all pass.yarn format:ci: clean.npx ng build: success.To re-check:
Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 5.5)
🤖 Generated with Claude Code