refactor(amber): remove the unused BackpressurePause - #8688
Merged
aglinxinyuan merged 1 commit intoSep 26, 2026
Merged
Conversation
BackpressurePause has had no production caller since apache#2237 moved flow control onto ActorMessage: backpressure now toggles a flag in DPThread and never goes through PauseManager. Only the PauseType and WorkerManagers specs still referenced it; their PauseManager cases now use the pause types production actually passes (OperatorLogicPause as a global pause, ECMPause as a per-channel pause).
Contributor
Automated Reviewer SuggestionsBased on the
|
Contributor
|
| config | throughput | MB/s | latency | max Δ latest / 7d | |
|---|---|---|---|---|---|
| 🔴 | bs=10 sw=10 sl=64 | 383 | 0.233 | 24,993/31,659/31,659 us | 🔴 +10.6% / 🔴 +89.7% |
| 🟢 | bs=100 sw=10 sl=64 | 805 | 0.491 | 124,684/136,774/136,774 us | 🟢 -5.8% / 🔴 +22.0% |
| ⚪ | bs=1000 sw=10 sl=64 | 909 | 0.555 | 1,101,138/1,137,272/1,137,272 us | ⚪ within ±5% / 🔴 +6.7% |
Baseline details
Latest main 33bd07b from same runner
| config | metric | PR | latest main | 7d avg | Δ latest | Δ 7d |
|---|---|---|---|---|---|---|
| bs=10 sw=10 sl=64 | throughput | 383 tuples/sec | 415 tuples/sec | 736.99 tuples/sec | -7.7% | -48.0% |
| bs=10 sw=10 sl=64 | MB/s | 0.233 MB/s | 0.253 MB/s | 0.45 MB/s | -7.9% | -48.2% |
| bs=10 sw=10 sl=64 | p50 | 24,993 us | 22,593 us | 13,174 us | +10.6% | +89.7% |
| bs=10 sw=10 sl=64 | p95 | 31,659 us | 34,954 us | 16,900 us | -9.4% | +87.3% |
| bs=10 sw=10 sl=64 | p99 | 31,659 us | 34,954 us | 19,889 us | -9.4% | +59.2% |
| bs=100 sw=10 sl=64 | throughput | 805 tuples/sec | 813 tuples/sec | 946.47 tuples/sec | -1.0% | -14.9% |
| bs=100 sw=10 sl=64 | MB/s | 0.491 MB/s | 0.496 MB/s | 0.578 MB/s | -1.0% | -15.0% |
| bs=100 sw=10 sl=64 | p50 | 124,684 us | 120,867 us | 105,257 us | +3.2% | +18.5% |
| bs=100 sw=10 sl=64 | p95 | 136,774 us | 145,177 us | 112,150 us | -5.8% | +22.0% |
| bs=100 sw=10 sl=64 | p99 | 136,774 us | 145,177 us | 125,962 us | -5.8% | +8.6% |
| bs=1000 sw=10 sl=64 | throughput | 909 tuples/sec | 914 tuples/sec | 973.64 tuples/sec | -0.5% | -6.6% |
| bs=1000 sw=10 sl=64 | MB/s | 0.555 MB/s | 0.558 MB/s | 0.594 MB/s | -0.5% | -6.6% |
| bs=1000 sw=10 sl=64 | p50 | 1,101,138 us | 1,085,086 us | 1,032,217 us | +1.5% | +6.7% |
| bs=1000 sw=10 sl=64 | p95 | 1,137,272 us | 1,158,909 us | 1,072,497 us | -1.9% | +6.0% |
| bs=1000 sw=10 sl=64 | p99 | 1,137,272 us | 1,158,909 us | 1,102,623 us | -1.9% | +3.1% |
Raw CSV
config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
0,10,10,64,20,522.84,200,128000,383,0.233,24992.72,31659.45,31659.45
1,100,10,64,20,2483.69,2000,1280000,805,0.491,124683.61,136773.92,136773.92
2,1000,10,64,20,21997.44,20000,12800000,909,0.555,1101137.88,1137272.09,1137272.09
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8688 +/- ##
============================================
- Coverage 92.72% 92.72% -0.01%
Complexity 4947 4947
============================================
Files 1243 1243
Lines 52682 52681 -1
Branches 6520 6520
============================================
- Hits 48850 48849 -1
Misses 2214 2214
Partials 1618 1618
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
kunwp1
approved these changes
Sep 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
Deletes
BackpressurePause. It is aPauseTypethat no production code has passed toPauseManagersince flow control moved ontoActorMessage. There is no behaviour change: +11/−19 lines.History
PauseManagerunder its own pause typepauseManager.pause(BackpressurePause)/resume(BackpressurePause)callsIt has been dead for nearly three years. Backpressure still works, but it now bypasses
PauseManager:Backpressure(enabled)arrives as anActorCommandand flipsDPThread.backpressureStatus. #4533 removed the siblingSchedulerTimeSlotExpiredPausefor the same reason.Any related issues, documentation, discussions?
Closes #8686
How was this PR tested?
No new tests. The two existing specs keep their cases with the fixtures swapped.
Locally, from the repo root with Java 17:
sbt "WorkflowExecutionService/Test/compile": success.sbt "WorkflowExecutionService/testOnly *PauseTypeSpec *WorkerManagersSpec": 27 tests, all pass.sbt "WorkflowExecutionService/scalafmtCheckAll" "WorkflowExecutionService/scalafixAll --check": clean.To re-check:
Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 5.5)
🤖 Generated with Claude Code