test(amber): cover computing unit worker args - #7192
Conversation
Automated Reviewer SuggestionsBased on the
|
|
| config | throughput | MB/s | latency | max Δ latest / 7d | |
|---|---|---|---|---|---|
| 🔴 | bs=10 sw=10 sl=64 | 396 | 0.242 | 26,917/34,531/34,531 us | 🔴 +13.1% / 🔴 +113.2% |
| ⚪ | bs=100 sw=10 sl=64 | 818 | 0.499 | 118,250/155,931/155,931 us | ⚪ within ±5% / 🔴 +40.8% |
| ⚪ | bs=1000 sw=10 sl=64 | 955 | 0.583 | 1,045,835/1,083,018/1,083,018 us | ⚪ within ±5% / ⚪ within ±5% |
Baseline details
Latest main 2388b85 from same runner
| config | metric | PR | latest main | 7d avg | Δ latest | Δ 7d |
|---|---|---|---|---|---|---|
| bs=10 sw=10 sl=64 | throughput | 396 tuples/sec | 418 tuples/sec | 765.25 tuples/sec | -5.3% | -48.3% |
| bs=10 sw=10 sl=64 | MB/s | 0.242 MB/s | 0.255 MB/s | 0.467 MB/s | -5.1% | -48.2% |
| bs=10 sw=10 sl=64 | p50 | 26,917 us | 23,796 us | 12,703 us | +13.1% | +111.9% |
| bs=10 sw=10 sl=64 | p95 | 34,531 us | 30,968 us | 16,199 us | +11.5% | +113.2% |
| bs=10 sw=10 sl=64 | p99 | 34,531 us | 30,968 us | 19,557 us | +11.5% | +76.6% |
| bs=100 sw=10 sl=64 | throughput | 818 tuples/sec | 809 tuples/sec | 965.22 tuples/sec | +1.1% | -15.3% |
| bs=100 sw=10 sl=64 | MB/s | 0.499 MB/s | 0.494 MB/s | 0.589 MB/s | +1.0% | -15.3% |
| bs=100 sw=10 sl=64 | p50 | 118,250 us | 118,410 us | 103,830 us | -0.1% | +13.9% |
| bs=100 sw=10 sl=64 | p95 | 155,931 us | 161,337 us | 110,778 us | -3.4% | +40.8% |
| bs=100 sw=10 sl=64 | p99 | 155,931 us | 161,337 us | 118,713 us | -3.4% | +31.4% |
| bs=1000 sw=10 sl=64 | throughput | 955 tuples/sec | 936 tuples/sec | 992.33 tuples/sec | +2.0% | -3.8% |
| bs=1000 sw=10 sl=64 | MB/s | 0.583 MB/s | 0.571 MB/s | 0.606 MB/s | +2.1% | -3.7% |
| bs=1000 sw=10 sl=64 | p50 | 1,045,835 us | 1,073,343 us | 1,016,959 us | -2.6% | +2.8% |
| bs=1000 sw=10 sl=64 | p95 | 1,083,018 us | 1,105,659 us | 1,062,501 us | -2.0% | +1.9% |
| bs=1000 sw=10 sl=64 | p99 | 1,083,018 us | 1,105,659 us | 1,082,611 us | -2.0% | +0.0% |
Raw CSV
config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
0,10,10,64,20,505.23,200,128000,396,0.242,26917.17,34531.14,34531.14
1,100,10,64,20,2444.10,2000,1280000,818,0.499,118249.77,155931.37,155931.37
2,1000,10,64,20,20934.29,20000,12800000,955,0.583,1045834.91,1083018.41,1083018.41There was a problem hiding this comment.
Pull request overview
Adds targeted ScalaTest coverage in the Amber/web layer for ComputingUnitWorker.parseArgs, validating expected option parsing and failure behavior for invalid inputs (empty args, repeated --serverAddr, unknown/malformed options). This supports the Amber computing-unit worker startup path by pinning current CLI parsing semantics.
Changes:
- Add a new
ComputingUnitWorkerSpeccovering empty input and--serverAddrparsing. - Assert “last one wins” behavior for repeated
--serverAddr. - Add negative tests for unknown options and missing option values (expecting
InvalidArgumentExceptionwith the current message).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7192 +/- ##
============================================
+ Coverage 80.73% 80.74% +0.01%
+ Complexity 3925 3924 -1
============================================
Files 1162 1160 -2
Lines 46264 45934 -330
Branches 5153 5118 -35
============================================
- Hits 37350 37089 -261
+ Misses 7243 7180 -63
+ Partials 1671 1665 -6
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
What changes were proposed in this PR?
Adds focused unit coverage for computing-unit worker command-line parsing, including empty input, repeated addresses, and malformed options.
Any related issues, documentation, discussions?
Closes #7189
How was this PR tested?
WorkflowExecutionService/testOnly org.apache.texera.web.ComputingUnitWorkerSpec— 5 passed.WorkflowExecutionService/Test/scalafmtAllandWorkflowExecutionService/Test/scalafixWorkflowExecutionService/Test/scalafmtCheckandWorkflowExecutionService/Test/scalafix --checkMutation proof (each production change was reverted):
--serverAddroptionWas this PR authored or co-authored using generative AI tooling?
Generated-by: Codex (GPT-5)