chore(deps): widen dremio/exasol/firebird/redshift/risingwave caps for SQLAlchemy 2.0 - #42891
Conversation
|
Bito Automatic Review Skipped - Branch Excluded |
✅ Deploy Preview for superset-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
…bump Notes the breaking dependency change for downstream consumers: custom db_engine_specs or extensions that touch SQLAlchemy internals directly should check the 1.4->2.0 migration guide, and the optional connector extras still capped below their own SQLAlchemy-2.0-only releases (either pending #42891 or blocked entirely on upstream) keep pulling 1.4-line dialect versions until their own caps move.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## experiment/sqla2-full-bump #42891 +/- ##
===========================================================
Coverage 65.80% 65.80%
===========================================================
Files 2842 2842
Lines 160960 160960
Branches 36921 36921
===========================================================
Hits 105917 105917
Misses 53019 53019
Partials 2024 2024
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…my 2.0 core bump dremio, exasol, firebird, redshift, and risingwave each cut hard from a SQLAlchemy-1.4-only line to a SQLAlchemy-2.0-only line with no dual-compat release in between. pyproject.toml already documented each cap as "bump in lockstep with Superset's own SQLAlchemy 2.0 core bump (discussion #40273), not before" -- that bump has now landed (#42803), so this widens all five to their 2.0-compatible ranges: - dremio: sqlalchemy-dremio>=1.2.1,<3.0.5 -> >=3.0.5,<4 - exasol: sqlalchemy-exasol>=2.4.0,<6.0.0 -> >=6.0.0,<8.0 - firebird: sqlalchemy-firebird>=0.8.0,<2.0.0 -> >=2.2.0 - redshift: sqlalchemy-redshift>=0.8.1,<0.9 -> >=1.0.0 - risingwave: sqlalchemy-risingwave>=1.4.1,<2.0.0 -> >=2.0.0 None of these five are pinned in requirements/base.txt, requirements/development.txt, or any other lockfile -- they're purely optional per-connector extras -- so no lockfile regeneration is needed alongside this pyproject.toml change. This does not close out discussion #40273's driver survey entirely: aurora-data-api, d1, kusto, solr, and ocient remain blocked on their own upstream SQLAlchemy 2.0 support (or, for ocient, unverified compatibility), independent of Superset's own bump.
97b7021 to
7cff874
Compare
… chore/bump-sqla2-compatible-driver-caps # Conflicts: # pyproject.toml
SUMMARY
Stacked on #42803 (the SQLAlchemy 2.0 + flask-sqlalchemy 3.1.1 core bump) — base branch is
experiment/sqla2-full-bump, notmaster. Rebase onto master once #42803 merges.pyproject.tomlalready had five optional DB-connector extras explicitly capped below their SQLAlchemy-2.0-only releases, each commented "bump in lockstep with Superset's own SQLAlchemy 2.0 core bump (discussion #40273), not before":dremiosqlalchemy-dremio>=1.2.1,<3.0.5>=3.0.5,<4exasolsqlalchemy-exasol>=2.4.0,<6.0.0>=6.0.0,<8.0firebirdsqlalchemy-firebird>=0.8.0,<2.0.0>=2.2.0redshiftsqlalchemy-redshift>=0.8.1,<0.9>=1.0.0risingwavesqlalchemy-risingwave>=1.4.1,<2.0.0>=2.0.0That core bump has now landed in #42803, so this widens all five. Each dialect cuts hard from a 1.4-only line to a 2.0-only line with no dual-compat release, hence the hard floor bump rather than a widened range. All five target versions confirmed to exist on PyPI.
None of the five are pinned in
requirements/base.txt,requirements/development.txt, or any other lockfile — they're pure optional per-connector extras — so no lockfile regeneration was needed alongside thepyproject.tomlchange.Does not close out discussion #40273's driver survey entirely. Five other extras remain blocked on their own upstream SQLAlchemy 2.0 support, independent of Superset's bump (see each package's comment /
known_incompatibilitiesmetadata in the correspondingdb_engine_specs/*.py):aurora-data-api— both available forks have unresolved SQLAlchemy 2.0 breaksd1— only release explicitly excludes SQLAlchemy 2.0kusto— upstream hard-pinssqlalchemy==1.4.*solr— unmaintained, hard-pinned to ~1.4.7ocient— closed-source vendor package, 2.0 support unverifiedTESTING INSTRUCTIONS
pyproject.toml-only change (no code paths touched). Verified all five target versions exist viapip index versions. Confirmed via./scripts/uv-pip-compile.shinputs (requirements/*.in) that none of these five extras feed any lockfile, so no regeneration is required.ADDITIONAL INFORMATION