fix(dashboard): mute the Group By display control loading spinner - #42879
Draft
sadpandajoe wants to merge 2 commits into
Draft
fix(dashboard): mute the Group By display control loading spinner#42879sadpandajoe wants to merge 2 commits into
sadpandajoe wants to merge 2 commits into
Conversation
The Group By display control in the dashboard filter bar rendered its column-loading spinner at full opacity and medium size, which is visually heavy for an inline secondary loading state. Render it with the small, muted Loading variant (40px, 0.25 opacity) to match the light-grey style expected for inline loading affordances. Adds a regression test that pins the card in its column-loading state and asserts the spinner is rendered small and muted. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #42879 +/- ##
==========================================
+ Coverage 66.37% 73.63% +7.26%
==========================================
Files 2857 1929 -928
Lines 161048 83547 -77501
Branches 37046 27236 -9810
==========================================
- Hits 106892 61522 -45370
+ Misses 52141 22025 -30116
+ Partials 2015 0 -2015
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Contributor
|
🎪 Showtime deployed environment on GHA for d324c98 • Environment: http://16.148.59.106:8080 (admin/admin) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
The Group By display control in the dashboard filter bar renders its column-loading spinner with the default
<Loading position="inline" />, i.e. full opacity and medium (70px) size. For an inline, secondary loading affordance this is visually heavy — the spinner should use the light grey/muted style, matching the muted inline variant already used byFilterValue.tsx.This change renders the spinner with the small, muted
Loadingvariant (size="s" muted→ 40px, 0.25 opacity) and adds a regression test that pins the card in its column-loading state and asserts the spinner is rendered small and muted.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before: while column options load, the control shows the default spinner — full opacity, 70px — which dominates the filter card.
After: the same loading state shows a 40px spinner at 0.25 opacity, reading as a light grey inline affordance.
(Before/after recordings to follow.)
TESTING INSTRUCTIONS
Automated:
npx jest src/dashboard/components/nativeFilters/FilterBar/FilterControls/GroupByFilterCard.test.tsx— the new test fails on master (spinner opacity 1, width 70px) and passes with this change (opacity 0.25, width 40px).ADDITIONAL INFORMATION