Skip to content

chore(deps-dev): update sqlalchemy-risingwave requirement from <2.0.0,>=1.4.1 to <3.0.0,>=1.4.1 - #42856

Merged
hainenber merged 2 commits into
masterfrom
dependabot/pip/sqlalchemy-risingwave-gte-2.1.0-and-lt-3.0.0
Aug 8, 2026
Merged

chore(deps-dev): update sqlalchemy-risingwave requirement from <2.0.0,>=1.4.1 to <3.0.0,>=1.4.1#42856
hainenber merged 2 commits into
masterfrom
dependabot/pip/sqlalchemy-risingwave-gte-2.1.0-and-lt-3.0.0

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Aug 6, 2026

Copy link
Copy Markdown
Contributor

Updates the requirements on sqlalchemy-risingwave to permit the latest version.

Changelog

Sourced from sqlalchemy-risingwave's changelog.

2.1.0 - 2026-06-18

Adds the psycopg3 driver path — synchronous and asynchronous — to the existing psycopg2 sync dialect. No behaviour on the existing risingwave+psycopg2:// URL changes; 2.1.0 is a backwards-compatible addition.

Added

  • psycopg3 driver support via risingwave+psycopg:// URLs. Sync engines resolve to RisingWaveDialect_psycopg; async engines resolve to RisingWaveDialect_psycopg_async via the sync class's get_async_dialect_cls override, keeping every RisingWave behaviour (compilers, capability flags, reflection, Superset cancel-query shim) consistent across both paths.
  • SQLAlchemy create_async_engine("risingwave+psycopg://...") is now supported. The sync RisingWaveDialect_psycopg.get_async_dialect_cls(...) dispatches to RisingWaveDialect_psycopg_async so both sync and async paths share the _RisingWaveCommon overrides.
  • Optional psycopg3 extras: pip install "sqlalchemy-risingwave[psycopg3]".
  • A documentation page at docs/async.md covering the async usage pattern, FastAPI sketch, the streaming visibility reminder, and the exact set of behaviours every PR validates against a real RisingWave instance in CI.
  • A runnable examples/async_usage.py script covering minimal SELECT, write → explicit FLUSH → read, and asyncio.gather concurrency.
  • README "Async support" section.

Changed

  • The driver-agnostic RisingWave behaviour has moved from the RisingWaveDialect class into a new _RisingWaveCommon mixin. The RisingWaveDialect name is preserved as an import alias on the psycopg2 path; downstream code that imports it from sqlalchemy_risingwave.base continues to work without modification.

Tests

The new merge-gating integration tests land alongside the dialect. They run against a real RisingWave instance via .github/workflows/test.yml and a failure blocks merge. The compliance.yml workflow remains advisory and is unchanged.

  • Cross-driver round trip: data written via psycopg2 sync is read back identically through psycopg3 sync and psycopg3 async, with an explicit FLUSH so RisingWave's streaming visibility window can't mask a driver-level mismatch.
  • Parametrised type round-trip matrix across driver (psycopg2, psycopg) × type (Integer, BigInteger, Float, String ASCII / unicode, UUID, Boolean true/false, LargeBinary).

... (truncated)

Commits

@dependabot dependabot Bot added dependabot pip Dependabot - pip related PRs labels Aug 6, 2026
@bito-code-review

bito-code-review Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Code Review Agent Run #e931d3

Actionable Suggestions - 0
Review Details
  • Files reviewed - 1 · Commit Range: 69229f0..69229f0
    • pyproject.toml
  • Files skipped - 0
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by Bito Logo

@rusackas

rusackas commented Aug 7, 2026

Copy link
Copy Markdown
Member

@dependabot recreate

@dependabot
dependabot Bot force-pushed the dependabot/pip/sqlalchemy-risingwave-gte-2.1.0-and-lt-3.0.0 branch from 69229f0 to 04000bb Compare August 7, 2026 12:56
@codecov

codecov Bot commented Aug 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.37%. Comparing base (79c2cd3) to head (99b497d).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #42856   +/-   ##
=======================================
  Coverage   66.37%   66.37%           
=======================================
  Files        2857     2857           
  Lines      161048   161048           
  Branches    37046    37046           
=======================================
+ Hits       106889   106892    +3     
+ Misses      52143    52141    -2     
+ Partials     2016     2015    -1     
Flag Coverage Δ
hive 38.26% <ø> (ø)
mysql 57.75% <ø> (ø)
postgres 57.80% <ø> (+<0.01%) ⬆️
presto 40.22% <ø> (ø)
python 59.20% <ø> (+<0.01%) ⬆️
sqlite 57.42% <ø> (ø)
unit 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bito-code-review bito-code-review Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review Agent Run #247a5a

Actionable Suggestions - 1
  • pyproject.toml - 1
Review Details
  • Files reviewed - 1 · Commit Range: 04000bb..04000bb
    • pyproject.toml
  • Files skipped - 0
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by Bito Logo

Comment thread pyproject.toml Outdated
# to the newest 1.4-only release for now. Bump to >=2.0.0 in lockstep with
# Superset's own SQLAlchemy 2.0 core bump (discussion #40273), not before.
risingwave = ["sqlalchemy-risingwave>=1.4.1, <2.0.0"]
risingwave = ["sqlalchemy-risingwave>=2.1.0, <3.0.0"]

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SQLAlchemy version gate violated

Bumping sqlalchemy-risingwave to >=2.1.0 violates the documented prerequisite in the comments above (lines 247-250). The comment explicitly states: "Bump to >=2.0.0 in lockstep with Superset's own SQLAlchemy 2.0 core bump (discussion #40273), not before." The core constraint in superset-core/pyproject.toml line 48 remains sqlalchemy>=1.4.0,<2.0, confirming the SQLAlchemy 2.0 migration has not occurred. Since sqlalchemy-risingwave>=2.1.0 requires SQLAlchemy 2.0+ (confirmed via vendor docs), installing the risingwave extra would create an unsatisfiable dependency.

Code Review Run #247a5a


Should Bito avoid suggestions like this for future reviews? (Manage Rules)

  • Yes, avoid them

@rusackas rusackas Aug 7, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, but this is already handled, sadpandajoe suggested keeping the floor at >=1.4.1 instead of jumping to >=2.1.0, so we widen the ceiling without actually forcing the SQLAlchemy 2.0-only releases in yet. Left the thread open for now since it wasn't marked resolved.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The suggestion provided by the reviewer is valid in its assessment that sqlalchemy-risingwave>=2.1.0 typically requires SQLAlchemy 2.0+. Since the project's core dependency remains on SQLAlchemy 1.4, this change would indeed create an unsatisfiable dependency. Keeping the floor at >=1.4.1 while widening the ceiling is an appropriate approach to maintain compatibility with the current core constraints.

pyproject.toml

risingwave = ["sqlalchemy-risingwave>=1.4.1, <2.0.0"]

Updates the requirements on [sqlalchemy-risingwave](https://github.com/risingwavelabs/sqlalchemy-risingwave) to permit the latest version.
- [Changelog](https://github.com/risingwavelabs/sqlalchemy-risingwave/blob/main/CHANGELOG.md)
- [Commits](https://github.com/risingwavelabs/sqlalchemy-risingwave/commits/v2.1.0)

---
updated-dependencies:
- dependency-name: sqlalchemy-risingwave
  dependency-version: 2.1.0
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
dependabot Bot force-pushed the dependabot/pip/sqlalchemy-risingwave-gte-2.1.0-and-lt-3.0.0 branch from 04000bb to be9ae43 Compare August 7, 2026 16:59
Comment thread pyproject.toml Outdated
@rusackas rusackas changed the title chore(deps-dev): update sqlalchemy-risingwave requirement from <2.0.0,>=1.4.1 to >=2.1.0,<3.0.0 chore(deps-dev): update sqlalchemy-risingwave requirement from <2.0.0,>=1.4.1 to <3.0.0,>=1.4.1 Aug 7, 2026
@bito-code-review

bito-code-review Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Code Review Agent Run #2184d0

Actionable Suggestions - 0
Filtered by Review Rules

Bito filtered these suggestions based on rules created automatically for your feedback. Manage rules.

  • pyproject.toml - 1
    • Incompatible dependency version upper bound · Line 251-251
Review Details
  • Files reviewed - 1 · Commit Range: be9ae43..99b497d
    • pyproject.toml
  • Files skipped - 0
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by Bito Logo

@hainenber
hainenber merged commit d80f4c8 into master Aug 8, 2026
70 checks passed
@hainenber
hainenber deleted the dependabot/pip/sqlalchemy-risingwave-gte-2.1.0-and-lt-3.0.0 branch August 8, 2026 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependabot pip Dependabot - pip related PRs size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants