chore(deps-dev): update sqlalchemy-risingwave requirement from <2.0.0,>=1.4.1 to <3.0.0,>=1.4.1 - #42856
Conversation
Code Review Agent Run #e931d3Actionable Suggestions - 0Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help |
|
@dependabot recreate |
69229f0 to
04000bb
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #42856 +/- ##
=======================================
Coverage 66.37% 66.37%
=======================================
Files 2857 2857
Lines 161048 161048
Branches 37046 37046
=======================================
+ Hits 106889 106892 +3
+ Misses 52143 52141 -2
+ Partials 2016 2015 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Code Review Agent Run #247a5a
Actionable Suggestions - 1
-
pyproject.toml - 1
- SQLAlchemy version gate violated · Line 251-251
Review Details
-
Files reviewed - 1 · Commit Range:
04000bb..04000bb- pyproject.toml
-
Files skipped - 0
-
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful
Bito Usage Guide
Commands
Type the following command in the pull request comment and save the comment.
-
/review- Manually triggers a full AI review. -
/pause- Pauses automatic reviews on this pull request. -
/resume- Resumes automatic reviews. -
/resolve- Marks all Bito-posted review comments as resolved. -
/abort- Cancels all in-progress reviews.
Refer to the documentation for additional commands.
Configuration
This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.
Documentation & Help
| # to the newest 1.4-only release for now. Bump to >=2.0.0 in lockstep with | ||
| # Superset's own SQLAlchemy 2.0 core bump (discussion #40273), not before. | ||
| risingwave = ["sqlalchemy-risingwave>=1.4.1, <2.0.0"] | ||
| risingwave = ["sqlalchemy-risingwave>=2.1.0, <3.0.0"] |
There was a problem hiding this comment.
Bumping sqlalchemy-risingwave to >=2.1.0 violates the documented prerequisite in the comments above (lines 247-250). The comment explicitly states: "Bump to >=2.0.0 in lockstep with Superset's own SQLAlchemy 2.0 core bump (discussion #40273), not before." The core constraint in superset-core/pyproject.toml line 48 remains sqlalchemy>=1.4.0,<2.0, confirming the SQLAlchemy 2.0 migration has not occurred. Since sqlalchemy-risingwave>=2.1.0 requires SQLAlchemy 2.0+ (confirmed via vendor docs), installing the risingwave extra would create an unsatisfiable dependency.
Code Review Run #247a5a
Should Bito avoid suggestions like this for future reviews? (Manage Rules)
- Yes, avoid them
There was a problem hiding this comment.
Good catch, but this is already handled, sadpandajoe suggested keeping the floor at >=1.4.1 instead of jumping to >=2.1.0, so we widen the ceiling without actually forcing the SQLAlchemy 2.0-only releases in yet. Left the thread open for now since it wasn't marked resolved.
There was a problem hiding this comment.
The suggestion provided by the reviewer is valid in its assessment that sqlalchemy-risingwave>=2.1.0 typically requires SQLAlchemy 2.0+. Since the project's core dependency remains on SQLAlchemy 1.4, this change would indeed create an unsatisfiable dependency. Keeping the floor at >=1.4.1 while widening the ceiling is an appropriate approach to maintain compatibility with the current core constraints.
pyproject.toml
risingwave = ["sqlalchemy-risingwave>=1.4.1, <2.0.0"]
Updates the requirements on [sqlalchemy-risingwave](https://github.com/risingwavelabs/sqlalchemy-risingwave) to permit the latest version. - [Changelog](https://github.com/risingwavelabs/sqlalchemy-risingwave/blob/main/CHANGELOG.md) - [Commits](https://github.com/risingwavelabs/sqlalchemy-risingwave/commits/v2.1.0) --- updated-dependencies: - dependency-name: sqlalchemy-risingwave dependency-version: 2.1.0 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
04000bb to
be9ae43
Compare
Code Review Agent Run #2184d0Actionable Suggestions - 0Filtered by Review RulesBito filtered these suggestions based on rules created automatically for your feedback. Manage rules.
Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help |
Updates the requirements on sqlalchemy-risingwave to permit the latest version.
Changelog
Sourced from sqlalchemy-risingwave's changelog.
... (truncated)
Commits