WW-5623 fix(core): HTML-encode form action in PostbackResult to prevent XSS#1701
Open
lukaszlenart wants to merge 1 commit into
Open
WW-5623 fix(core): HTML-encode form action in PostbackResult to prevent XSS#1701lukaszlenart wants to merge 1 commit into
lukaszlenart wants to merge 1 commit into
Conversation
…nt XSS PostbackResult.doExecute() embeds finalLocation into a <form action=""> attribute via raw string concatenation. A double quote in the location breaks out of the attribute, enabling reflected XSS. The response Content-Type is text/html. Form field names and values elsewhere in the same class are properly URL-encoded via URLEncoder.encode(); the action attribute was not encoded at all. Wrap finalLocation with StringEscapeUtils.escapeHtml4() before embedding it in the form tag, consistent with the encoding approach used in DefaultActionProxy, Property, and TextProviderHelper. Adds three regression tests in PostbackResultTest: - testFormActionHtmlEscaping: XSS payload with attribute breakout - testFormActionEscapesAllHtmlSpecialChars: covers ", &, <, > - testFormActionCleanLocationUnchanged: regression for clean URLs
|
lukaszlenart
requested review from
aleksandr-m,
cnenning,
jogep,
kusalk,
rgielen,
sdutry and
yasserzamani
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports #1653 to the 6.x line.
PostbackResult.doExecute()embedsfinalLocationinto a<form action="">attribute via raw string concatenation. Wrap it withStringEscapeUtils.escapeHtml4(), consistent with the encoding approach used inDefaultActionProxy,Property, andTextProviderHelper.See #1653 for the full analysis.
Adds three regression tests covering the XSS payload, all special characters, and the clean-URL regression case.
Fixes WW-5623.