Conversation
getSupervisorPageInfo returned a worker summary for every topology assigned to the supervisor and only left out the per-component task counts for topologies the caller cannot read. Worker placement is otherwise only returned by getTopologyInfo and getTopologyPageInfo, which require read access to the topology, so the supervisor page is now consistent with them and omits the workers of topologies the caller is not allowed to read. The supervisor summary on the same page still reports the aggregate slot, memory and CPU usage of the node, so the capacity view is unchanged. Admins and users with read access see the same page as before.
rzo1
force-pushed
the
fix/supervisor-page-readable-workers
branch
from
September 18, 2026 17:24
ae78ca8 to
62c8135
Compare
GGraziadei
approved these changes
Sep 18, 2026
GGraziadei
left a comment
GGraziadei
left a comment
Member
There was a problem hiding this comment.
Hi @rzo1 this PR correctly adds the check on user's topologies. Thanks, LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getSupervisorPageInforeturned a worker summary for every topology assigned to the supervisor. For topologies the caller cannot read, it only left outcomponentNumTasks. Worker placement is otherwise only returned bygetTopologyInfoandgetTopologyPageInfo, which require read access to the topology. The supervisor page now matches them and omits the workers of topologies the caller is not allowed to read. It uses the existingfilterAuthorized("getTopology", ...)check, and topologies that fail it are no longer loaded at all.The supervisor summary on the same page still reports the node's aggregate slot, memory and CPU usage, so the capacity view is unchanged. Admins and users with read access see the same page as before.
docs/STORM-UI-REST-API.mdnow says theworkerslist is limited to readable topologies.Extends
NimbusClojurePortTest. The existing supervisor page test now also asserts the returned worker, and a new test covers a caller without read access.