Skip to content

Fix checkstyle violations (#8585 - Phase 3 - Part 1) #8702

Merged
reiabreu merged 5 commits into
apache:masterfrom
sigee:fix-checkstyle-violations-part-1
May 22, 2026
Merged

Fix checkstyle violations (#8585 - Phase 3 - Part 1) #8702
reiabreu merged 5 commits into
apache:masterfrom
sigee:fix-checkstyle-violations-part-1

Conversation

@sigee
Copy link
Copy Markdown
Member

@sigee sigee commented May 21, 2026

No description provided.

@rzo1 rzo1 added this to the 3.0.0 milestone May 21, 2026
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't the license headers too trimmed on this one?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right as it is shortened drastically.
The reason is that the same license header text was there multiple times (4 times exactly) and I left only a single one.
"This file originally comes from the Apache Hadoop project. Changes have been made to the file."
If you see the original file in the hadoop project: https://github.com/apache/hadoop/blob/71d216d8c80e7e2682471a2b9819c36a1558033d/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/WritableUtils.java
It only contains a short license header.
There was no value in the duplication in my opinion.

@sigee sigee marked this pull request as draft May 22, 2026 07:14
@sigee
Copy link
Copy Markdown
Member Author

sigee commented May 22, 2026

I've just noticed that multiple files line separator changed from LF to CRLF. I'll fix them today.

@sigee sigee force-pushed the fix-checkstyle-violations-part-1 branch from c4fb6c6 to b9203cb Compare May 22, 2026 08:08
@sigee sigee marked this pull request as ready for review May 22, 2026 08:13
@sigee sigee requested a review from reiabreu May 22, 2026 08:24
@reiabreu reiabreu merged commit b068fc2 into apache:master May 22, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants