[SPARK-59597][SQL] Avoid quadratic CTE attribute restoration - #58873
Open
bhollis-dbx wants to merge 1 commit into
Open
bhollis-dbx wants to merge 1 commit into
bhollis-dbx wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Use
AttributeMapwhen restoring attributes from CTE references to CTE definitions inPushdownPredicatesAndPruneColumnsForCTEDef. This replaces a linear semantic search per attribute with expression-ID lookup.Why are the changes needed?
The current implementation linearly searches the CTE attribute mapping for every restored attribute, making planning quadratic in CTE width. The cost reaches tens of milliseconds per rule application for wide CTEs and is repeated for CTE references and optimizer iterations.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Ran
PushdownPredicatesForCTEDefStalenessSuite. All 7 tests passed.Local benchmark output for the full rule:
Was this patch authored or co-authored using generative AI tooling?
Generated-by: OpenAI Codex (GPT-5)