Skip to content

New UI: Use URL from window.location #4281

Merged
malliaridis merged 5 commits intoapache:mainfrom
renatoh:use-url-from-window.location
Apr 20, 2026
Merged

New UI: Use URL from window.location #4281
malliaridis merged 5 commits intoapache:mainfrom
renatoh:use-url-from-window.location

Conversation

@renatoh
Copy link
Copy Markdown
Contributor

@renatoh renatoh commented Apr 13, 2026

At different places, e.g. on the placeholder of the welcome screen, 127.0.0.1:8983 was hard coded, that causes issues when Solr was opened using a different URL, e.g. localhost or any other URL.
Now the URL is taken from window.location.origin. Doing so the todo in Main.kt could be removed.
Additionally the right URL is now pre-populated to solr_url_input on the welcome screen, rather than having hard coded 127.0.0.1:8983 as place-holder in it.

renatoh added 2 commits April 13, 2026 14:45
…rather than a hard coded, and potentially wrong, placeHolder URL
@renatoh renatoh changed the title Use url from window.location New UI: Use URL from window.location Apr 13, 2026
Copy link
Copy Markdown
Contributor

@epugh epugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this with "http://localhost:8983" and "http://127.0.0.1:8983" and it worked as expected.... I am not a kotlin expert, so hesitant to approve and merge. Hopefully @malliaridis can approve!

@epugh epugh requested a review from malliaridis April 13, 2026 15:36
@epugh
Copy link
Copy Markdown
Contributor

epugh commented Apr 13, 2026

Tests are running.

@renatoh
Copy link
Copy Markdown
Contributor Author

renatoh commented Apr 13, 2026

@epugh Thanks a lot for testing:) Despite of having used Kotlin in the past, I have no experience with Kotlin's Multiplatform, so definitely a must to get it checked by someone who actually understands it.

Copy link
Copy Markdown
Contributor

@malliaridis malliaridis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for addressing this issue, it was bothering me a lot during development, but I didn't took the time to address it myself.

Your implementation looks clean and makes proper use of the expect / actual pattern of Kotlin Multiplatform. I have added a note about the reason for the previous implementation with the placeholder, so that you have a bit more context.

I have only one concern about the platform-specific file namings, that normally are suffixed with [File].[platform].kt, for example PlatformUtils.wasmJs.kt. I have faced some build issues when the implementation was merged together for individual targets. You don't have to change anything yet. If that happens in a release, we will address it separately (I am also investigating the cases when this issue happens).

@renatoh Feel free to add me for any kotlin-specific changes as reviewer, and if you are interested I can provide a few more details about Kotlin stuff. I would also be very grateful if you have the time to review some of my changes or give the implementation of new features a shot. :)

@malliaridis
Copy link
Copy Markdown
Contributor

@renatoh I leave the decision of how to resolve my feedback topics to you, and once resolved we can merge this PR. :)

…rather than a hard coded, and potentially wrong, placeHolder URL
@renatoh
Copy link
Copy Markdown
Contributor Author

renatoh commented Apr 14, 2026

@renatoh Feel free to add me for any kotlin-specific changes as reviewer, and if you are interested I can provide a few more details about Kotlin stuff. I would also be very grateful if you have the time to review some of my changes or give the implementation of new features a shot. :)

Are there also ticket which require mainly backend work? If so, I am happy to give it the shot. I am not good with front-end stuff and have never enjoyed it.

@malliaridis
Copy link
Copy Markdown
Contributor

Are there also ticket which require mainly backend work? If so, I am happy to give it the shot. I am not good with front-end stuff and have never enjoyed it.

Sure, there is plenty of things to do in backend. Specifically for the new UI / consumers, there are some API related changes that would be useful, specficically around configurations, but also other areas. I have only created SOLR-18191 so far, which is about validation of API requests. Feel free to take a look. I plan to create a few more API related issues once I reach that state in the frontend. :)

@malliaridis malliaridis merged commit fb7377c into apache:main Apr 20, 2026
2 checks passed
malliaridis pushed a commit that referenced this pull request Apr 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants