Add a none provider to the ai-agent-conversation module - #14064
Merged
wu-sheng merged 1 commit intoSep 10, 2026
Merged
Conversation
The GraphQL query module requires the module, so the '-' selector cannot remove it. SW_AI_AGENT_CONVERSATION=none selects a provider that disables the ai_agent_session_data and ai_agent_session_flow models before the core module scans them, so neither table nor the BanyanDB group they are the only members of is created, answers both conversation queries empty with an errorReason, and registers no conversation view route.
kezhenxu94
commented
Sep 9, 2026
| @@ -131,6 +131,7 @@ The conversation page of the UI makes one call, this route, and nothing else. | |||
| ```yaml | |||
| ai-agent-conversation: | |||
| selector: ${SW_AI_AGENT_CONVERSATION:default} | |||
Member
Author
There was a problem hiding this comment.
I’ll leave it to you to decide if we should disable it by default @wu-sheng
wu-sheng
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ai-agent-conversationmodule, added in #14057, has no way to be turned off. The-selector cannot remove it, becauseGraphQLQueryProvider.requiredModules()listsAIAgentConversationModule.NAMEfor its two conversation resolvers, so a-makesBootstrapFlow.makeSequence()fail the boot withModuleNotFoundException.SW_AI_AGENT_CONVERSATION=nonenow selects a provider that does nothing:It disables the
ai_agent_session_dataandai_agent_session_flowmodels inprepare(), which runs for every provider before anystart(), and so before the core module's@Streamscan. Neither table is created on any storage, nor the BanyanDBrecordsAIAgentgroup, whose only members they are. A record with no worker is dropped byRecordStreamProcessor, so the bundled LAL rule stores nothing either; droppingai-agentfromSW_LOG_LAL_FILESskips the verification work as well.It registers a query service that answers
listConversationsandgetConversationRawFilesempty with anerrorReason, so the GraphQL module still boots and its queries still answer.It registers no HTTP handler, so the conversation view route is a 404.
Update the
CHANGESlog.