chore: install linters in make env, exclude *.txt from the license check - #412
Merged
Conversation
this file was likely committed by mistake, it contributes nothing but fail the license checker
…nse check The plugin compose file installs /app/requirements.txt, so deleting it broke the sw_threading test. Bring it back and exclude *.txt from the license header check instead — per-plugin requirements.txt files are generated by tests/plugin/conftest.py and can never carry a header.
kezhenxu94
changed the title
make env, exclude *.txt from the license check
`unify` and its `untokenize` dependency are unmaintained; their sdists use `ast.Str.s`, removed in Python 3.12, and neither publishes a wheel. Installing the lint group from `make env` therefore broke the Check Plugin Doc job, which runs on Python 3.14. Move the group into its own `env-lint` target that `lint` and `fix` depend on, so `make env` works on every supported interpreter and only the lint targets need one that can build `unify`.
wu-sheng
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make lintassumed thelintdependency group was already installed, so a freshmake envleft it failing. This installs the group as part ofmake env.While doing that,
tests/plugin/web/sw_threading/requirements.txtwas deleted because ittripped the license header check. That was wrong — the plugin's
docker-compose.ymlrunspip install -r /app/requirements.txt, so its absence made the provider container exit 1and broke the
sw_threadingplugin test. The file is restored, and*.txtis excludedfrom the license check instead: the per-plugin
requirements.txtfiles are generated attest time by
tests/plugin/conftest.pyand can never carry a header.Verified with
make license— no tracked file fails.