[ISSUE #11087] Validate lite.bind.topic for LiteTopic groups - #11088
Open
yx9o wants to merge 1 commit into
Open
Conversation
yx9o
commented
Sep 9, 2026
Contributor
- Fixes [Enhancement] Validate lite.bind.topic with standard topic validation #11087 .
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #11088 +/- ##
=============================================
- Coverage 48.93% 48.93% -0.01%
+ Complexity 13842 13841 -1
=============================================
Files 1382 1383 +1
Lines 101597 101608 +11
Branches 13212 13214 +2
=============================================
+ Hits 49716 49720 +4
+ Misses 45851 45847 -4
- Partials 6030 6041 +11 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
RockteMQ-AI
approved these changes
Sep 9, 2026
RockteMQ-AI
left a comment
Contributor
There was a problem hiding this comment.
Summary
This PR strengthens validation for lite.bind.topic in LiteTopic consumer groups by:
- Replacing
!= nullchecks withStringUtils.isNotBlank()inLiteMetadataUtil— catches empty-string values that previously passed through. - Introducing
TopicNameAttribute(extendingStringAttribute) to validate topic names at the attribute level viaTopicValidator.validateTopic(). - Adding comprehensive tests for empty/blank
lite.bind.topicin both single and batch delete scenarios, plus attribute-level validation.
The defense-in-depth approach (attribute-level validation + runtime isNotBlank checks) is solid. Tests are thorough and cover edge cases well. LGTM.
Automated review by github-manager
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.