Skip to content

[ISSUE #11087] Validate lite.bind.topic for LiteTopic groups - #11088

Open
yx9o wants to merge 1 commit into
apache:developfrom
yx9o:dev-0909
Open

[ISSUE #11087] Validate lite.bind.topic for LiteTopic groups#11088
yx9o wants to merge 1 commit into
apache:developfrom
yx9o:dev-0909

Conversation

@yx9o

@yx9o yx9o commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.93%. Comparing base (fd2dc2f) to head (73d4db3).
⚠️ Report is 2 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop   #11088      +/-   ##
=============================================
- Coverage      48.93%   48.93%   -0.01%     
+ Complexity     13842    13841       -1     
=============================================
  Files           1382     1383       +1     
  Lines         101597   101608      +11     
  Branches       13212    13214       +2     
=============================================
+ Hits           49716    49720       +4     
+ Misses         45851    45847       -4     
- Partials        6030     6041      +11     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RockteMQ-AI RockteMQ-AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary

This PR strengthens validation for lite.bind.topic in LiteTopic consumer groups by:

  1. Replacing != null checks with StringUtils.isNotBlank() in LiteMetadataUtil — catches empty-string values that previously passed through.
  2. Introducing TopicNameAttribute (extending StringAttribute) to validate topic names at the attribute level via TopicValidator.validateTopic().
  3. Adding comprehensive tests for empty/blank lite.bind.topic in both single and batch delete scenarios, plus attribute-level validation.

The defense-in-depth approach (attribute-level validation + runtime isNotBlank checks) is solid. Tests are thorough and cover edge cases well. LGTM.


Automated review by github-manager

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] Validate lite.bind.topic with standard topic validation

3 participants