fix(tools): stop feeding the cold data flow ctr payload to printf as a format string

[zjncs]

Motivation

GetColdDataFlowCtrInfoSubCommand.getAndPrint pretty-prints the JSON returned by the broker and passes it to printf as the format string:

String formatStr = JSON.toJSONString(jsonObject, JSONWriter.Feature.PrettyFormat);
System.out.printf(formatStr);

The payload is keyed by consumer group names, and % is a legal character in consumer group and topic names — the validation regex is ^[%|a-zA-Z0-9_-]+$ (it exists precisely to allow the %RETRY% / %RETRY%-style prefixes). A group like order%group therefore makes the command die halfway through the report:

java.util.MissingFormatArgumentException: Format specifier '%g'

(any % in the group name triggers MissingFormatArgumentException, UnknownFormatConversionException or UnknownFormatFlagsException depending on the following character — none of the command output is printed.)

Modification

Print the payload literally:

System.out.print(formatStr);
System.out.printf("%n");

Verification

mvn -pl tools test -Dtest=GetColdDataFlowCtrInfoSubCommandTest

fail-before (fix reverted, test kept) — the mocked broker response contains a legal group name order%group:

Tests run: 1, Failures: 0, Errors: 1
testPrintsEntriesWhoseGroupNameContainsPercent  <<< ERROR!
java.util.MissingFormatArgumentException: Format specifier '%g'

pass-after:

Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
BUILD SUCCESS

and the captured stdout contains the untouched group name order%group.

No associated issue; found by code inspection.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[RockteMQ-AI]

LGTM — correct fix. System.out.printf(formatStr) would throw UnknownFormatConversionException if the JSON payload contains % characters (legal in consumer group names like %RETRY%). Switching to System.out.print(formatStr) is the right approach.

Good test coverage verifying that % in the payload is preserved correctly.

---

Automated review by github-manager-bot