[fix][ml] Fix batch ACK index loss when recovering cursor from MetadataStore - #26474
Open
void-ptr974 wants to merge 1 commit into
Open
[fix][ml] Fix batch ACK index loss when recovering cursor from MetadataStore#26474void-ptr974 wants to merge 1 commit into
void-ptr974 wants to merge 1 commit into
Conversation
…taStore Assisted-by: Codex
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When a cursor is cleanly closed using the MetadataStore persistence path, partial batch acknowledgment indexes are written to
ManagedCursorInfo. ThecursorsLedgerId == -1recovery path restored the mark-delete position, individual deleted-message ranges, and properties, but skippedbatchedEntryDeletionIndexInfos. After topic unload/reload or another cursor reconstruction, already acknowledged messages within a batch could therefore be redelivered.Modifications
ManagedCursorInfoin the MetadataStore recovery path.Verifying this change
./gradlew :managed-ledger:test --tests '*ManagedCursorBatchAckRecoveryTest' -PtestRetryCount=0 -PtestFailFast=false./gradlew :pulsar-broker:test --tests '*ManagedCursorBatchAckMetadataStoreRecoveryTest' -PtestRetryCount=0 -PtestFailFast=false./gradlew quickCheck