PHOENIX-7840 UpdateCacheIT recategorize as NeedsOwnMiniClusterTest#2457
Open
apurtell wants to merge 1 commit intoapache:masterfrom
Open
PHOENIX-7840 UpdateCacheIT recategorize as NeedsOwnMiniClusterTest#2457apurtell wants to merge 1 commit intoapache:masterfrom
apurtell wants to merge 1 commit intoapache:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UpdateCacheIT.helpTestUpdateCachewraps the singletonConnectionQueryServicesin a Mockito spy so the resultingPhoenixConnection's services field is the spy and every internal call routed back through it is retained with strong references to every argument. That retention layered on top of an already heavy long-lived CQS singleton can tip the surefire runner intoOutOfMemoryError. The fix recategorizes the suite asNeedsOwnMiniClusterTest