PHOENIX-7834 CDCBaseIT do not force-delete a never-upserted row#2451
Open
apurtell wants to merge 1 commit intoapache:masterfrom
Open
PHOENIX-7834 CDCBaseIT do not force-delete a never-upserted row#2451apurtell wants to merge 1 commit intoapache:masterfrom
apurtell wants to merge 1 commit intoapache:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CDCBaseIT.generateMutationshas a second-half "force a delete if there was none so far" branch that flipsisDelete=truewithout checking whether the candidate row was ever upserted in this run, so when random batch participation has skipped a key in every prior batch the forcedDELETElands on a non-existent row and produces an HBase tombstone with no matching put. The data table view sees no change, and a later legitimate upsert for the same key surfaces as the next CDC change event on aforView=trueCDC while the expected change list still has the tombstone marked as a delete, trippingCDCBaseIT.verifyChangesViaSCNwithComparisonFailure expected:<delete> but was:<upsert> in CDCQueryIT.testSelectGeneric[forView=true, encodingScheme=TWO_BYTE_QUALIFIERS, multitenant=false, tableSaltBuckets=null, withSchemaName=false, caseSensitiveNames=false]. The fix gates the forced-delete branch onmutatedRows.contains(rows.get(j))so a delete is only ever forced on a row that has already been upserted.