PHOENIX-7833 CDCBaseIT/CDCQueryIT keep manual edge installed after applyMutations#2450
Open
apurtell wants to merge 1 commit intoapache:masterfrom
Open
PHOENIX-7833 CDCBaseIT/CDCQueryIT keep manual edge installed after applyMutations#2450apurtell wants to merge 1 commit intoapache:masterfrom
apurtell wants to merge 1 commit intoapache:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CDCBaseIT.applyMutationsinstalls aManualEnvironmentEdgeso eachaddChangepinsEnvironmentEdgeManager.currentTimeMillis()to the row'schangeTS, then callscommitter.reset()whose default implementation isEnvironmentEdgeManager.reset(), revertingcurrentTimeMillis()to the wall clock. The rest of the CDC test body easily takes longer thanCDCQueryIT.MAX_LOOKBACK_AGE = 10s, so any SCN-bounded read whose smallest SCN is the earliestchangeTStripsQueryCompiler.verifySCNwithERROR 538 "Cannot use SCN to look further back in the past beyond the configured max lookback age". TheIndexToolmapper shares the sameEnvironmentEdgeManagerstatic state in the in-process mini-cluster andPhoenixServerBuildIndexInputFormathits the sameERROR 538while compiling its SCN-bounded plan. The fix stops callingcommitter.reset()at the end ofapplyMutations, instead pinninginjectEdgethe highestchangeTSseen across all batches so subsequent SCN-bounded reads of the just-applied mutations stay inside the max-lookback window, and adds aCDCQueryIT.afterTest()that callsEnvironmentEdgeManager.reset()to preserve per-test isolation.