PHOENIX-7830 De-flake MutableIndexFailureIT#2447
Open
apurtell wants to merge 1 commit intoapache:masterfrom
Open
PHOENIX-7830 De-flake MutableIndexFailureIT#2447apurtell wants to merge 1 commit intoapache:masterfrom
apurtell wants to merge 1 commit intoapache:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MutableIndexFailureIThas two independent bugs that cause flaky and cascading test failures. First, the outer class declares its own static volatileFAIL_WRITEfield that shadowsFailingRegionObserver.FAIL_WRITE, so the finally block intestIndexWriteFailureresets the dead outer field and leavesFailingRegionObserver.FAIL_WRITEstuck at true when the test fails mid-way, breaking subsequent tests in the same fork. Second,FailingRegionObserver.TOGGLE_FAIL_WRITE_FOR_RETRYis not declared volatile even though it is written by app threads inaddRowsInTableDuringRetryand read by region server handler threads inpreBatchMutate, so the RS thread can observe a stale false, miss the retry toggle, and surface aCommitExceptionthat fails the assertion. The fix removes the shadowed outerFAIL_WRITEfield, retargets the finally block to resetFailingRegionObserver.FAIL_WRITE, and marksFailingRegionObserver.TOGGLE_FAIL_WRITE_FOR_RETRYvolatile to guarantee cross-thread visibility.