PHOENIX-7828 De-flake UCFWithDisabledIndexIT#2445
Open
apurtell wants to merge 1 commit intoapache:masterfrom
Open
PHOENIX-7828 De-flake UCFWithDisabledIndexIT#2445apurtell wants to merge 1 commit intoapache:masterfrom
apurtell wants to merge 1 commit intoapache:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UCFWithDisabledIndexITwas flaky due to two independent races.First, the tests swap
MetaDataEndpointImplonSYSTEM.CATALOGwith aTestMetaDataEndpointImplthat throwsDoNotRetryIOException("Not allowed")on every getTable RPC, butTestUtil.addCoprocessor()only polls until the masterTableDescriptoris updated and does not wait for region servers to reopenSYSTEM.CATALOGwith the new coprocessor. This creates five race sites where client work runs before the swap is visible.Second,
testUcfWithNoGetTableCallscreated its data table withUPDATE_CACHE_FREQUENCY=20000, then performed 7 DDLs and 7 UPSERTs before a finalSELECTthat is expected to be served entirely from the client metadata cache. Whenever wall-clock delay betweenCREATE TABLEand theSELECTexceeded 20 s the cache expired, a getTable RPC was issued, and the stub rejected it.Add a
waitForCoprocessorOnSystemCatalog(Class)helper that pollsregion.getCoprocessorHost().findCoprocessor(className)on everySYSTEM.CATALOGregion (up to 10 s) and call it after each of the five swaps.Change
testUcfWithNoGetTableCalls'sCREATE TABLEfromUPDATE_CACHE_FREQUENCY=20000toUPDATE_CACHE_FREQUENCY=NEVER, which decouples the assertion from wall-clock time.