PHOENIX-7826 MetadataGetTableReadLockIT wait for coprocessor swap to land#2443
Open
apurtell wants to merge 1 commit intoapache:masterfrom
Open
PHOENIX-7826 MetadataGetTableReadLockIT wait for coprocessor swap to land#2443apurtell wants to merge 1 commit intoapache:masterfrom
apurtell wants to merge 1 commit intoapache:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
testBlockedReadDoesNotBlockAnotherReadtest installs aBlockingMetaDataEndpointImplcoprocessor onSYSTEM.CATALOGand expects a worker thread's query to hit it and signal a latch the main thread is waiting on, butTestUtil.addCoprocessor()only updates the masterTableDescriptorand doesn't wait for region servers to reopen the region with the new coprocessor, so if the query reaches the oldMetaDataEndpointImplfirst the latch is never signaled and the main thread hangs until the Surefire/Failsafe fork times out. The fix is to add a helper that polls eachSYSTEM.CATALOGregion's coprocessor host (viafindCoprocessorfor up to 10 seconds and call it afteraddCoprocessorso the coprocessor swap is guaranteed visible before the worker thread starts.