PHOENIX-7824 ConcurrentMutationsExtendedIT fix wrong TimeUnit on doneSignal.await#2441
Open
apurtell wants to merge 1 commit intoapache:masterfrom
Open
PHOENIX-7824 ConcurrentMutationsExtendedIT fix wrong TimeUnit on doneSignal.await#2441apurtell wants to merge 1 commit intoapache:masterfrom
apurtell wants to merge 1 commit intoapache:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two call sites in
ConcurrentMutationsExtendedITcallsdoneSignal.await(ROW_LOCK_WAIT_TIME + 5000, TimeUnit.SECONDS), butROW_LOCK_WAIT_TIMEis the HBase row-lock-wait constant in milliseconds (default 10000). PassingTimeUnit.SECONDSturned the intended 15-second wait into a 4+ hour timeout. Additionally, the return value of await was unchecked, allowing silent under-completion to bypass the verification phase and let the test "pass" by accident.