PHOENIX-7820 ConnectionQueryServicesImpl.createSnapshot bounded retry on transient exception#2438
Open
apurtell wants to merge 1 commit intoapache:masterfrom
Open
PHOENIX-7820 ConnectionQueryServicesImpl.createSnapshot bounded retry on transient exception#2438apurtell wants to merge 1 commit intoapache:masterfrom
apurtell wants to merge 1 commit intoapache:masterfrom
Conversation
… on transient exception
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ConnectionQueryServicesImpl.createSnapshot()invokesadmin.snapshot()during the Phoenix upgrade path. Transient HMaster issues surface as upgrade failures because of the lack of retry. The master's per-table lock can be briefly held by a concurrent admin operation, or RPC-level retries can resubmit an already-accepted snapshot request, causing the master to reject the duplicate. The fix is to wrap the snapshot call in a small bounded retry loop (5 attempts, 1 s backoff).