PHOENIX-7817 Resolve Omid transaction manager via provider singleton view#2435
Open
apurtell wants to merge 1 commit intoapache:masterfrom
Open
PHOENIX-7817 Resolve Omid transaction manager via provider singleton view#2435apurtell wants to merge 1 commit intoapache:masterfrom
apurtell wants to merge 1 commit intoapache:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OmidTransactionClientcaptures the provider'sHBaseTransactionManagerat construction time.OmidTransactionContextin turn caches that same reference in a private field. When a prior test class shuts down OMID's TSO together with its mini-cluster, the next test class reuses the stale wrapper and is dispatched to the dead executor. The symptom is aRejectedExecutionExceptionoriginating from the OMID TSOClient state-machine executor.In production the singleton's manager is set exactly once and never replaced, but the test framework exercises the swap path between classes within a single Surefire/Failsafe fork.
Fix:
OmidTransactionClientbecomes a thin view onto the singleton's currentHBaseTransactionManager. It resolvesprovider.transactionManageron every call togetTransactionClient().transactionManageris marked volatile so test-framework injection is published to other threads without synchronization.In production the dynamic lookup is functionally identical to caching.